54345 - Installation does not install webbrwsr.dll

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[Adam Lock]

The Mozilla control creates a webbrowser object to do embed Gecko. 
Unfortunately, the object cannot be created because webbrwsr.dll is not 
installed. The control prints a message that it cannot create a critical 
component and does not function correctly.

Comment 1

[Adam Lock]

Attachment: Proposed patch adds the missing DLL

Comment 2

[Adam Lock]

Adding embed keyword

Comment 3

[Sean Su]

FYI: Whoever owns webbrwsr.dll needs to update packages-win.

Comment 4

[Phil Peterson]

Not holding PR3 for this; marking nsbeta3-.

Comment 5

[Adam Lock]

Nominating rtm

Comment 6

[Daniel Veditz [:dveditz]]

The install team is not responsible for keeping the package lists up to date, we
cannot know what's required in each component though we do try to help.

Sean is pretty booked for RTM, please try to check this in yourself or get
another browser folk involved. r=dveditz for the patch and module owner approval
from me. You need a super reviewer before setting rtm+

Comment 7

[Scott Collins]

looks simple and correct to me, a=scc

Comment 8

[Phil Peterson]

PDT would like to know why seamonkey needs this on the branch? Is this an
embedding issue which should go on the trunk?

Comment 9

[Adam Lock]

The branch should either get this fix or you should take mozctl.dll out of NS 
6.0 Final, Either way the package list needs to be updated because the Mozilla 
control won't work without the webbrwsr.dll.

Comment 10

[Daniel Veditz [:dveditz]]

Changing to [rtm+] to get on PDT radar: What is it guys? add webbrwsr.dll or 
remove mozctl.dll? Adding webbrwsr.dll can't break the product, it would only 
enable people to experiment with mozctl.dll if they want without having to 
download a Mozilla build to do so.

Comment 11

[Phil Peterson]

PDT would like an explanation of the problem in English. We don't know what
users gain by including one dll, or how they're hurt by removing the other dll.

Comment 12

[Adam Lock]

The Mozilla ActiveX control wrapper is used by people like VB programmers who
want to use Gecko without wading into C++, XPCOM etc. It's also API compatible
with the Internet Explorer control so programmers can easily migrate their apps
from IE to Mozilla.

The control is implemented in mozctl.dll. When instantiated it tries to create
the webbrowser XPCOM object. This object is implemented in webbrwsr.dll and is
how people embed Gecko. If webbrwsr.dll isn't there, the Mozilla control cannot
create the webbrowser object and reports a critical error. In other words, the
Mozilla control is useless without webbrwsr.dll.

So the choice boils down to this:

1. Remove mozctl.dll from the package list and lose the Mozilla ActiveX control
2. Add webbrwsr.dll to the package list and fix the Mozilla ActiveX control.

Neither choice will affect anything except the Mozilla ActiveX control. I would
personally like to do 2). Webbrwser.dll is a 40k DLL.

Comment 13

[Phil Peterson]

PDT marking [rtm++] for option (2), but please land quickly since this ++ won't
last forever.

Comment 14

[Adam Lock]

Fix checked into branch and trunk

Comment 15

[Henrik Gemal]

2000102808 has the file webbrwsr.dll in the components directory