54475 - XUL template builder should eagerly mark leaves as "no work required"

Status: VERIFIED FIXED

(Core :: XUL, defect, P2)

Description

[Chris Waterson]

When creating content from a XUL template, the template builder currently marks
*all* newly created elements as "may require more work". This is silly, because
the template builder can very cheaply determine that it's building a leaf
element (does the template from which its copying have zero kids?), and
initialize the newly created element as "no work required". Doing so avoids a
wasted trip through the template builder at a later point in time, only to find
that no work needed to be done!

It turns out that this is accounting for about 6% of the time (after applying
hyatt's prototype optimization, attribute minimization from bug 53627, and
removing nsStyleUtils::IsSimpleXLink per bug 53620) spent during thread pane
scrolling. I'll attach a brain-dead patch in a sec...

Comment 1

[Chris Waterson]

Attachment: see if we're at the leaf in the template; if so, mark the generated content as complete

Comment 2

[David Hyatt]

Looks correct.  r=hyatt.

Comment 3

[Robert John Churchill]

Looks good to me too.  r=rjc

Comment 4

[Chris Waterson]

Fix checked in on tip. Leaving bug open in hopes of getting in on RTM branch

Comment 5

[Michael La Guardia]

Marking "needinfo." Will reconsider for inclusion once there is a reviewed and
super reviewed patch.

Comment 6

[Michael La Guardia]

Oops.  I made a mistake while updating this bug yesterday.  In our conversation
about it, we decided to give th bug an RTM++.  Please go ahead and check this in.

Comment 7

[Chris Waterson]

Fix checked in on the branch.

Comment 8

[John Morrison]

Just nodding my head and trying not to look too stupid here ... verified fixed.