545132 - Add "donate contributions to Mozilla Foundation" to the AMO developers UI

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, enhancement)

Description

[Chelsea Novak [:chelsea]]

Several add-on developers have suggested that adding an option to "donate contributions to Mozilla Foundation" to the AMO UI to make it less confusing for authors and contributors. 

Here's the blog post that started the conversation for further reference. 
http://chelseanovak.wordpress.com/2010/02/08/contributing-to-the-mozilla-foundation-via-amo/#comments

Comment 1

[Nick Nguyen [:osunick]]

I'd say for general direction we should try to make this generic so that add-ons developers can solicit contributions for any third party which they support, with MoFo being a suggested choice.

Comment 2

[Chelsea Novak [:chelsea]]

WFM. 

We might want to add something in the text that encourages them to let the beneficiary organization know that they'll be passing on contributions that way.

Also point out that it needs to be an org that uses PayPal, right?

Comment 3

[Nick Nguyen [:osunick]]

Mocks from chowse: http://people.mozilla.com/~chowse/drop/amo/moz-contribs/

For 01, I'd say this doesn't really convey that donation is different han contribution.

Also, we need to think about the 'meet the developer' page as it's very developer centric.  Something like adding a block to this page (example: https://addons.mozilla.org/en-US/firefox/addon/1833/developers)

IIRC, Chelsea had a hard time fitting the language into this page, so we should figure out how to add or change content on this page that explains the developer's chosen cause.

Of course this has implications on the admin tools as well.

Comment 4

[Chelsea Novak [:chelsea]]

I agree with you comments re: mock up 1. What about the following text:

"Enjoy this Add-on? Make a donation oh behalf of the developer"

I like the first pop-up option with less text and links to more information. 

In terms of the Meet the developer content I agree that it would be great for developers to talk about their cause.

Comment 5

[Nick Nguyen [:osunick]]

New mock!  See attached.  Spec:

1. Update DevCP to add "Third party donations".
2. If third party donations are enabled, then the paypal id used overrides the one entered in the normal contributions box.  This box should be grayed out and cleared.
3. clicking preview pops up the dialog as shown in the mockup with the entered values.  If no values are entered for link and organization, preview should be disabled.
4. Text on category pages and listings (where we go directly to paypal) should say "Like this Add-on? Make a donation to <a>org_name</a>."
5. See mocks for updated text on meet the developer and details pages
6. All 'annoying' features are retained.

Comment 6

[Jeff Balogh (:jbalogh)]

(In reply to comment #5)
> New mock!  See attached.  Spec:

I do not see anything attached.

Comment 7

[Nick Nguyen [:osunick]]

Attachment: latest mock for third party donations

Comment 8

[Wladimir Palant]

I suspect that The text will sound ugly (In reply to comment #5)
> 4. Text on category pages and listings (where we go directly to paypal) should
> say "Like this Add-on? Make a donation to <a>org_name</a>."

I suspect that this sentence will give translators some headaches. Creating sentences by inserting a random phrase works well in English but not necessarily in other languages, I am usually trying to avoid it. Though in this case it will probably help that org_name usually isn't something that needs to be declinated.

Comment 9

[Wil Clouser [:clouserw]]

@Wladimir: Yeah, it can be tough, but as long as we write a good L10n comment to let them know what org_name is, I think it will be ok.

@Nick: This sentence in the mockup doesn't make sense to me:  "If you enable this feature during the checkbox..."

Comment 10

[Nick Nguyen [:osunick]]

"with the checkbox"  sorry

Comment 11

[Barry Chen]

Currently the modal dialog is only displayed if there's a suggested amount for the contribution, should this also apply to the third party donation preview?  That is, preview won't be enabled unless the developer has entered a suggested amount.  The suggested amount is part of the dialog after all.

Comment 12

[Barry Chen]

Attachment: alter addons table for third party donations

ALTER SQL on the `addons` table to add four columns, with one per form element shown in the mock up.  Two of fields are localized.

Comment 13

[Barry Chen]

Attachment: addon third party donations patch

Patch for implementing third party donations.

The form does not look like @osunick's mock up because the translation box is used for a couple of the fields.  The suggested amount is also required to enable the preview, because the amount is part of the preview content.  The suggested amount field is pretty far away from the preview link though. :-/

Comment 14

[Wil Clouser [:clouserw]]

Comment on attachment 452418 [details]
alter addons table for third party donations

I'm not thrilled about adding 4 more columns to a huge table that will only be used for, like, 7 add-ons.  Maybe we can figure out something better with the marketplace.

Anyway, this is an r- because each of these ADD COLUMN statements takes about 45 seconds to run and locks the table.  If you combine them it'll cut our downtime by a decent chunk.

Comment 15

[Wil Clouser [:clouserw]]

(In reply to comment #13)
> Created an attachment (id=452421) [details]
> addon third party donations patch
> 
> Patch for implementing third party donations.
> 
> The form does not look like @osunick's mock up because the translation box is
> used for a couple of the fields.  The suggested amount is also required to
> enable the preview, because the amount is part of the preview content.  The
> suggested amount field is pretty far away from the preview link though. :-/

Yeah, I see what you mean.  I think this needs some UX review, in addition to how it looks, I think the checkbox to enable is unnecessary and it should be clear that you can either do 1st party or 3rd party donations, with a single "enable" checkbox.  The whole thing is supposed to have new mockups in early July anyway...

I started looking at your patch and you're in the unenviable position of working on remora still. :-/  I stole skeen away last week to migrate pages from remora -> zamboni and he's been finishing them up.  The short story is, all the front end pages that use that contribution form are served from python now, so the front end changes are out of date.

The dev tools changes work (with some minor tweaks), but I don't think launching them with their current face is a great idea, especially when they are going to be redone shortly.  /me will talk on IRC

Comment 16

[Nick Nguyen [:osunick]]

So does this mean we're blocked on design, or can we just put forth our best effort once we emerge from the twilight zone that is 5.11.x?

Comment 17

[Wil Clouser [:clouserw]]

I think the design should be looked at and incorporated into the new pages that chowse is finishing up right now

Comment 18

[Wil Clouser [:clouserw]]

This is done on the new pages, scheduled to go live by the end of the year.