54524 - FindFrameWithContent doesn't deal with XBL <children> insertion points

Status: RESOLVED FIXED

(Core :: XBL, defect, P3)

Description

[David Hyatt]

We're ending up doing all sorts of bad things (like mistakenly recreating 
frames) because the function FindFrameWithContent isn't savvy enough about 
XBL-interleaved anonymous content.  It fails to find frames because it assumes 
the content trees and frame trees match perfectly (an incorrect assumption).

This is why the XBL sticky note test is broken.

Comment 1

[David Hyatt]

This is a regression in my XBL test suite.  I'm guessing something related to 
:hover got patched or fixed to be better recently and that exposed the bug in 
FindFrameWithContent.

Will attach patch shortly.  Nominating dogfood, since I'm trying to keep all XBL 
testcases working, and having one broken interferes with my testing.

Comment 2

[David Hyatt]

Attachment: Fix to make sure anonymous frames are crawled.

Comment 3

[David Hyatt]

Looking for a review for the attached patch.

Comment 4

[Marc Attinasi]

The change looks good (although I have to admit I don't really understand what
the parentScope concept is all about...). r=attinasi

Comment 5

[David Hyatt]

The basic idea is that the content tree can look like this...

A --> B

but the frame tree can look like this...

A --> (C) --> B

The check asks if the child frame (in this case C) was generated from A.  If so, 
you crawl into it.  Basically I'm ensuring we crawl into anonymous frames that 
have interposed themselves between the frames for parent and child content 
nodes.

Comment 6

[Jim Roskind]

For dogfood rating: Please explain why this is a stopper bug, and for whom.
Thanks,
Jim

Comment 7

[David Hyatt]

I have a set of 5 regression tests for XBL that are accessible from the debug 
menu.  Those tests should all be kept in working order.  When one of them 
breaks, it means XBL has regressed.  That's why I have the tests in the first 
place. :)

Comment 8

[David Hyatt]

Fixed on trunk.  Not critical for branch.