54726 - Add link to W3C Validator

Status: VERIFIED FIXED

(Core :: DOM: Editor, enhancement, P3)

Description

[Peter Lubczynski]

It would be really nice to include a link to the W3C HTML Validation Service in
Composer to help people write correct HTML. The validator can be found at:
http://validator.w3.org/ and there's a nice place for this link would be under
the Edit menu, next to Check Spelling.

Comment 1

[Peter Lubczynski]

oops, I mean Composer not Compositor.

Comment 2

[rubydoo123]

good idea, but we have an internal parser that also validates, but setting to
future for consideration after rtm

Comment 3

[rubydoo123]

setting to accept to get it off the new radar

Comment 4

[rubydoo123]

the goal is to do the following:
1. add a menu item under Edit -- Check Document
2. when Check Document is selected, a browser window will be opened, the 
document http://validator.w3.org/file-upload.html will be displayed with the 
file name added to the File: field.
3. the user seelcts Validate this document button

an alternative solution would be to wrap the W3C validation tool with our 
application, allowing for offline validation.

Comment 5

[rubydoo123]

moving to 1.0 and assigning to akkana

Akkana, the last discussion about this incliuded the following:

When the user selects Edit|Validate, a browser window sould be opened, the local
path name of the file should be sent to the validation tool and inserted in the
text field (this could be accomplished by having a local copy of the initial
validation page and populating it with the pathname). I would suspect there is
some way where the submission of that page could also be triggered without user
interaction. Ryan attempted to try and figure that out, but got stuck on that
function.

Comment 6

[Akkana Peck]

Here's the patch.  Does it do everything it needs to?  If so, it's ready for review.

Comment 7

[Akkana Peck]

Attachment: patch: pop up validator window

Comment 8

[Akkana Peck]

Oh, forgot to mention: this has only been tested on linux so far.  In theory it
should work on all platforms, but we need to make sure, especially mac.  It
might be that document.location.pathname doesn't map to local file syntax, in
which case I'll probably need platform help to figure out how to map to platform
file names.

Kathy, when you have some time, can you try this patch on mac and see what sort
of file name appears in the window, and whether it works as intended?

I've removed the commented out section in nsValidateCommand.doCommand -- forgot
to remove it before I made the patch (doesn't matter for testing, just code
prettiness).

Comment 9

[Daniel Bratell]

beppe, it is probably a bad idea to do automatic uploading for privacy reasons.

Comment 10

[Akkana Peck]

This is a user-initiated action, and even after selecting the menu item, the
user has to click a submit button in the validator window before the validator
actually sees the contents of the file.  Neither the filename nor the contents
are sent out on the net until the user has done this.

Does that help with the privacy issue, Daniel?  Or are there other precautions
we should take, or warnings we should offer the user?

Comment 11

[Daniel Bratell]

Maybe I exagerated. When thinking of it I don't see the problem. The user will 
obviously be aware of the upload.

Comment 12

[Akkana Peck]

Cc msanz for localization of new menu item.

Comment 13

[Akkana Peck]

Using this, I noticed that sometimes I wanted to validate a page before I'd
modified it locally, or after publishing.  We should be able to validate from
the web as well as from a local file.  So I updated the code to be smarter about
that and handle both the file: and the everything-else cases.  See the new patch.

Comment 14

[Akkana Peck]

Attachment: smarter patch: handle both local and remote cases

Comment 15

[Akkana Peck]

Fix is in.

Comment 16

[sujay]

verified.