55080 - nsMenu::AttributeChanged fails to return a value

Status: VERIFIED FIXED

(Core :: XUL, defect, P3)

Description

[Simon Fraser [no longer active]]

When nsMenu::AttributeChanged bails with the test
  if((mMacMenuID <= 5) && (mMacMenuID >= 2))

it fails to return a value. Here's the fix:

Index: mozilla/widget/src/mac/nsMenu.cpp
===================================================================
RCS file: /cvsroot/mozilla/widget/src/mac/nsMenu.cpp,v
retrieving revision 1.85
diff -b -c -2 -r1.85 nsMenu.cpp
*** nsMenu.cpp	2000/09/22 06:03:08	1.85
--- nsMenu.cpp	2000/10/03 19:42:00
***************
*** 1487,1491 ****
  
      if((mMacMenuID <= 5) && (mMacMenuID >= 2)) 
!       return;
      
      ::DeleteMenu(mMacMenuID);
--- 1487,1491 ----
  
      if((mMacMenuID <= 5) && (mMacMenuID >= 2)) 
!       return NS_OK;
      
      ::DeleteMenu(mMacMenuID);

Comment 1

[Simon Fraser [no longer active]]

Nominate for RTM. Trivial fix, could fix some unknown menu handling errors.

Comment 2

[Kathleen :Brade]

r=brade

Comment 3

[Peter Trudelle]

rtm-, helpwanted, future

Comment 4

[Simon Fraser [no longer active]]

Huh? this is such a trivial change, all I need is sr=saari, and it's in.

Comment 5

[saari (gone)]

The change is fine with me, I'm just not allowed to check it in <shrug> Don't
kill me, I didn't make the rules.

Comment 6

[Simon Fraser [no longer active]]

saari: put a sr= here, and we'll try again.

Comment 7

[saari (gone)]

yeah, sr=saari

Comment 8

[Simon Fraser [no longer active]]

rtm++, pretty please?

Comment 9

[Jim Roskind]

Changing to rtm double plus.

Don't these items show up in warnings... or are we overloaded on that front
these days?

Comment 10

[Simon Fraser [no longer active]]

Fix checked in on trunk and branch.

Comment 11

[Simon Fraser [no longer active]]

Yes, this did show up as a warning.

Comment 12

[John Morrison]

verified fixed on branch and trunk by virtue of my friend, Bonsai.