55634 - Position of horizontal divider not maintained in current AB session

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Address Book & Contacts, defect)

Description

[Oliver Klee]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; WinNT4.0; en-US; m18) Gecko/20001006
BuildID:    2000100604

The layout of the adresse book (the position of the dividers) should be kept across sessions.			

Reproducible: Always
Steps to Reproduce:
1. In address book, change the layout by moving the dividers.
2. Close the address book. You don't need to close Mozilla.
3. Restart address book.

Actual Results:  The layout has been changed back to some standard layout.

Expected Results:  The layout should have been kept.

Comment 1

[Keyser Sose]

Reporter is this still a problem in the latest nightlies?

Comment 2

[Asa Dotzler [:asa]]

Confirmed on Mozilla trunk builds
linux 110908 RedHat 6.2
win32 110904 NT 4
mac 110908 Mac OS9
Vertical splitter persists location but horizontal splitter does not.

Comment 3

[scottputterman]

reassigning to chuang.

Comment 4

[fenella]

Qa-assigned-to myself.

Comment 5

[Oliver Klee]

Adding mozilla1.0 proposal.

Comment 6

[scottputterman]

reassigning to racham.

Comment 7

[scottputterman]

Marking worksforme.  I moved column splitters and the sidebar splitter, closed
the window, reopened it, and my positions persisted.

Comment 8

[Oliver Klee]

Reopening. With 2001100503 Win2k, the column splitter is remembered fine, but
the splitter under the list of cards isn't.

Comment 9

[Michael Buckland]

Discussed in 2/25 bug meeting with Mktng, PjM, Engineering.  Decision to minus.

Comment 10

[esther]

Using build 20020225 on winxp and mac the following changes to Address Book work
ok and hold their changes:
collapsing/expanding the vertical splitter
collapsing/expanding the horizontal splitter
resizing the column widths
columns displayed

What doesn't hold is if the horizontal splitter is moved to postions other than
expand or collapse, examples:
results window shows 17 cards, bar move to show 7 close & reopen leaves 12
cards.  results window shows 12 cards, bar move to show 6 close & reopen leaves
12 cards
results window shows 12 cards, bar move to show 24 close & reopen leaves 21 cards

Comment 11

[Ninoschka Baca]

Copied from bug# 64303
"trunk build 2002-01-02-03: WinMe
trunk build 2002-01-02-08: Linux RH 7.1
Interesting that I could only reproduce this after closing and opening the
Address Book within the same session. If I resize the divider in the AB,
exit/restart then the position seems to be remembered."

Comment 12

[Ninoschka Baca]

*** Bug 64303 has been marked as a duplicate of this bug. ***

Comment 13

[Ninoschka Baca]

Changed summary from "layout of address book not kept across AB sessions" to 
"Position of horizontal divider not maintained in current AB session"

Comment 14

[Ninoschka Baca]

Marking nsbeta1 again. Polish bug.

Comment 15

[Samir Gehani]

Mail triage team: nsbeta1-

Comment 16

[(not reading, please use [e-mail] instead)]

mass re-assign.

Comment 17

[Stefan Borggraefe]

Attachment: Patch

Fixes the bug.

Comment 18

[Stefan Borggraefe]

*** Bug 206856 has been marked as a duplicate of this bug. ***

Comment 19

[Stefan Borggraefe]

Comment on attachment 132871 [details] [diff] [review]
Patch

David: this is similar to bug 220727.

Comment 20

[Stefan Borggraefe]

Taking.

Comment 21

[Stefan Borggraefe]

.

Comment 22

[Stephen Donner [:stephend] Not actively reading bugmail]

C:\moz_src\mozilla\mailnews\addrbook\resources\content>cvs commit -m "Bug 55634.
  Position of horizontal divider not maintained in current AB session.  patch by
 Stefan Borggraefe <[e-mail]> r=neil, sr=bienvenu" addressbook.x
ul
Checking in addressbook.xul;
/cvsroot/mozilla/mailnews/addrbook/resources/content/addressbook.xul,v  <--  add
ressbook.xul
new revision: 1.167; previous revision: 1.166
done

C:\moz_src\mozilla\mailnews\addrbook\resources\content>cvs commit -m "Bug 55634.
  Position of horizontal divider not maintained in current AB session.  patch by
 Stefan Borggraefe <[e-mail]> r=neil, sr=bienvenu" abResultsPane
Overlay.xul
Checking in abResultsPaneOverlay.xul;
/cvsroot/mozilla/mailnews/addrbook/resources/content/abResultsPaneOverlay.xul,v
 <--  abResultsPaneOverlay.xul
new revision: 1.17; previous revision: 1.16
done

Comment 23

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using 2004-07-25-09 on Windows XP.