557234 - [skiplist] Add nsACString_internal::Assign to socorro skiplists

Status: RESOLVED FIXED

(Socorro :: Infra, task)

Description

[Wayne Mery (:wsmwk)]

ref https://wiki.mozilla.org/Breakpad/SkipListhttps://wiki.mozilla.org/Breakpad/SkipList

After consulting with bienvenu on IRC ...

There are a crashes in Thunderbird and perhaps Firefox where signature ending with nsACString_internal::Assign or nsACString_internal* isn't sufficient signature [1]. Indeed nsCString::nsCString or nsCString* or other frames (eg nsCAutoString) may need to be skipped [2].  

Leaving this unconfirmed until we've decided exactly what combo of changes is needed.
All crashes are Thunderbird unless otherwise noted


[1] nsACString_internal::Assign 

bp-2a717d6a-4729-41f9-bbae-4c5402100315
0	mozcrt19.dll	strlen	 strlen.asm:81
1	xpcom_core.dll	nsACString_internal::Assign	xpcom/string/src/nsTSubstring.cpp:351
2	thunderbird.exe	nsMsgSearchTerm::MatchRfc822String	mailnews/base/search/src/nsMsgSearchTerm.cpp:1231 

bp-0876c73f-c414-4ccf-8539-b62542100404
0	mozcrt19.dll	strlen	 strlen.asm:69
1	xpcom_core.dll	nsACString_internal::Assign	xpcom/string/src/nsTSubstring.cpp:351
2	thunderbird.exe	nsImapUrl::AddOnlineDirectoryIfNecessary	mailnews/imap/src/nsImapUrl.cpp:785 

[2] nsCString::nsCString, etc
bp-1f9401aa-4f99-46e8-ba51-801f52100403 
0	mozcrt19.dll	strlen	 strlen.asm:69
1	xpcom_core.dll	nsACString_internal::Assign	xpcom/string/src/nsTSubstring.cpp:351
2	thunderbird.exe	nsCString::nsCString	objdir-tb/mozilla/dist/include/string/nsTString.h:80
3	thunderbird.exe	nsImapProtocol::CreatePossibleTrashName	mailnews/imap/src/nsImapProtocol.cpp:7348 

bp-9da491db-1769-4a14-ad80-6e7c32100402  nsCString::nsCString nsCAutoString::nsCAutoString
0	mozcrt19.dll	strlen	 strlen.asm:81
1	xpcom_core.dll	nsACString_internal::Assign	xpcom/string/src/nsTSubstring.cpp:351
2	thunderbird.exe	nsCAutoString::nsCAutoString	objdir-tb/mozilla/dist/include/string/nsTString.h:505
3	thunderbird.exe	nsChromeRegistry::ProcessManifestBuffer	chrome/src/nsChromeRegistry.cpp:2373 

bp-436008fe-3376-4856-8cd1-d3c632100309
0	mozcrt19.dll	strlen	 strlen.asm:69
1	xpcom_core.dll	nsACString_internal::Assign	xpcom/string/src/nsTSubstring.cpp:351
2	thunderbird.exe	nsCAutoString::operator=	objdir-tb/mozilla/dist/include/string/nsTSubstring.h:367
3	thunderbird.exe	nsImapUrl::SetUri	mailnews/imap/src/nsImapUrl.cpp:1218 


---- 

And are cases where nsACString, nsCString, etc should not be skipped?

nsCString
TB http://crash-stats.mozilla.com/query/query?product=Thunderbird&version=ALL%3AALL&date=&range_value=7&range_unit=days&query_search=signature&query_type=startswith&query=nsCString&build_id=&process_type=all&do_query=1
FF http://crash-stats.mozilla.com/query/query?product=Thunderbird&version=ALL%3AALL&date=&range_value=6&range_unit=days&query_search=signature&query_type=startswith&query=nsCString&build_id=&process_type=all&do_query=1

nsACSTring
TB http://crash-stats.mozilla.com/query/query?product=Thunderbird&version=ALL%3AALL&date=&range_value=7&range_unit=days&query_search=signature&query_type=startswith&query=nsACString&build_id=&process_type=all&do_query=1
FF http://crash-stats.mozilla.com/query/query?product=Firefox&version=ALL%3AALL&date=&range_value=1&range_unit=days&query_search=signature&query_type=startswith&query=nsACString&build_id=&process_type=all&do_query=1

Comment 1

[Laura Thomson :laura]

Did you work out what changes you wanted?

Comment 2

[Laura Thomson :laura]

Waiting on info to implement.

Comment 3

[Robert Kaiser]

1) Wayne, is something still needed to be done here?
2) If so, what exactly should be added to which skiplist (prefix or ignore list)?
3) Once you know that, can you clear up with string devs if that sounds good to be done?

Comment 4

[Wayne Mery (:wsmwk)]

Please add nsACString_internal::Assign.* to the prefix skiplist.

This will help expose distinct signatures for Thunderbird backend and protocol crashes. And afaict does not substantially impact firefox signatures (definitely no topcrashes) https://crash-stats.mozilla.com/query/?product=Firefox&version=Firefox%3A25.0a1&version=Firefox%3A24.0a2&version=Firefox%3A23.0b10&version=Firefox%3A22.0&version=Firefox%3A26.0a1&version=Firefox%3A25.0a2&version=Firefox%3A24.0b1&version=Firefox%3A23.0&version=Firefox%3A23.0b9&version=Firefox%3A23.0b8&version=Firefox%3A23.0b7&version=Firefox%3A23.0b6&version=Firefox%3A23.0b5&version=Firefox%3A23.0b4&version=Firefox%3A23.0b3&version=Firefox%3A23.0b2&version=Firefox%3A23.0b1&version=Firefox%3A22.0b6&version=Firefox%3A22.0b5&version=Firefox%3A22.0b4&version=Firefox%3A21.0&range_value=1&range_unit=weeks&date=08%2F06%2F2013+18%3A00%3A00&query_search=signature&query_type=contains&query=nsACString_internal%3A%3AAssign&reason=&release_channels=&build_id=&process_type=any&hang_type=any

Comment 5

[Wayne Mery (:wsmwk)]

Hi Laura. I thought this had been scheduled. But perhaps lost during the search improvements because it's still an issue. Can this be pushed this week?

This will also help #5 crash in https://crash-stats.mozilla.com/topcrasher/products/Thunderbird/versions/24.0.1 - https://crash-stats.mozilla.com/report/list?product=Thunderbird&range_value=7&range_unit=days&date=2013-10-26&signature=mozalloc_abort%28char+const*+const%29+|+NS_DebugBreak+|+nsACString_internal%3A%3AAssign%28nsACString_internal+const%26%29&version=Thunderbird%3A24.0.1

Comment 6

[Wayne Mery (:wsmwk)]

lars, can  you perhaps hook me up?

Comment 7

[K Lars Lohn [:lars] [:klohn]]

Attachment: PR 1668 - adds "nsACString_internal::Assign.*" to the prefix skiplist.

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/85132794a70a1cab41577f7362f0ffde2fa60ff4
Merge pull request #1668 from twobraids/skiplist-nsACString_internal

Fixes Bug 557234 adds nsACString_internal::... to prefix skiplist

Comment 9

[Robert Kaiser]

Comment on attachment 830819 [details] [review]
PR 1668 - adds "nsACString_internal::Assign.*" to the prefix skiplist.

I guess it's OK, though we never heard from dev related to that code.