558820 - Visual tweaks for new Personas galleries

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Chris Howse [:chowse]]

Attachment: Persona gallery dimensions and colors

The Persona galleries could use some visual touch-ups; the current design has some legibility and layout problems, particularly with lighter-colored Personas.

I've attached a contact sheet with dimensions and colors for the gallery, which should improve clarity and make better use of space.

Comment 1

[Wil Clouser [:clouserw]]

Craig, can you look at this?  The page we're talking about is https://preview.addons.mozilla.org/z/en-US/firefox/personas/abstract

Comment 2

[Craig Cook (:craigcook)]

(In reply to comment #1)
Just to clarify my task here, am I only making some space and color adjustments to the existing markup (with thumbnails only, no titles or ratings etc.), or does the page need some new markup to match the PDF (adding titles, author, rating, etc.)?

Comment 3

[Chris Howse [:chowse]]

(In reply to comment #2)
> Just to clarify my task here, am I only making some space and color adjustments
> to the existing markup (with thumbnails only, no titles or ratings etc.), or
> does the page need some new markup to match the PDF (adding titles, author,
> rating, etc.)?

These changes are strictly cosmetic: spacing, color, and fonts. All the necessary content was added as part of bug 554367.

Comment 4

[Craig Cook (:craigcook)]

Updated in r65984, mostly padding and margin adjustments. Preview at http://mozilla.focalcurve.com/zamboni/personas.php

Comment 5

[Chris Howse [:chowse]]

Looks better, but still a few nits:

* The thumbnails are missing the blue (white on hover) borders.
* The top-left decals need to be smaller (11px) and match the color or the borders.

Also, do you have a preview in the 3-col galleries (e.g. http://bit.ly/a9fvVc)? The sizing/spacing issues are more pronounced there.

Comment 6

[Craig Cook (:craigcook)]

(In reply to comment #5)
> Also, do you have a preview in the 3-col galleries (e.g. http://bit.ly/a9fvVc)?
> The sizing/spacing issues are more pronounced there.

I was only given the one link (in comment 1) and no clear directive on what exactly was wrong with it (since the attached PDF in no way matched the page I was referred to), so I've had to do some guesswork on what actually needed fixing. I'll make these other changes and get started on the full gallery page now. Are there any other pages I should be looking at?

Comment 7

[Chris Howse [:chowse]]

(In reply to comment #6)
> I was only given the one link (in comment 1) and no clear directive on what
> exactly was wrong with it (since the attached PDF in no way matched the page I
> was referred to), so I've had to do some guesswork on what actually needed
> fixing. I'll make these other changes and get started on the full gallery page
> now. Are there any other pages I should be looking at?

Sorry for the lack of clarity. For 5.9, there should only be 3 page variations that need these changes:

Category pages, e.g. https://preview.addons.mozilla.org/z/en-US/firefox/personas/abstract
Metacategory pages, e.g. https://preview.addons.mozilla.org/z/en-US/firefox/personas/?sort=up-and-coming
General gallery pages, e.g. https://preview.addons.mozilla.org/z/en-US/firefox/personas/abstract?sort=up-and-coming

Comment 8

[Craig Cook (:craigcook)]

Further changes added in r66008 

Listing page preview at http://mozilla.focalcurve.com/zamboni/personas-listing.php

Galactus is the most awesome placeholder ever.

Comment 9

[Chris Howse [:chowse]]

Attachment: Final tweaks

These look brilliant, Craig! I've only a few more suggestions, but I think this patch should fulfill them. Thanks for humoring my Persona OCD. :)

BTW, what happened to all my Planet Earth personas? :O

Comment 10

[Craig Cook (:craigcook)]

(In reply to comment #9)
> Created an attachment (id=439447) [details]
> Final tweaks

Patched in r66014

Comment 11

[Wil Clouser [:clouserw]]

Thanks for taking care of this guys!