55974 - alert/confirm dialogs from xpi display bad text on title bar

Status: VERIFIED FIXED

(Core Graveyard :: Installer: XPInstall Engine, defect, P4)

Description

[Jimmy Lee]

Build: 2000-10-10-09-MN6(WIN), 2000-10-10-10-MN6(MAC), 2000-10-10-10-MN6(LINUX)

1. From http://jimbob/trigger3.html, click Functional drop-down and choose
   f_alertconfirm
2. Click Trigger case button
3. Click OK button from XPInstall confirm dialog
4. Click OK/Cancel button as alert and confirm dialogs appear

RESULT:
This broke on 10/4/00.  Before this date, no text appeared from the title bar on 
alert/confirm dialogs.

From Windows NT, garbage characters appear on the title bar.  From Linux, 
"mozilla-bin" appears as the titlebar text instead of "alert" and "confirm", 
respectively.  From Mac, no text appears instead of "alert" and "confirm", 
respectively.

I am using http://jimbob/bugs/confirm_it.html to compare behavior of 
alert/confirm dialog.  Dialogs appear correct when called from this html page.

EXPECTED RESULT:
"alert" and "confirm" are the title bar text for these types of dialogs when 
called from xpi packages.

Comment 1

[Jimmy Lee]

Windows 98 also shows garbage characters as the titlebar text for alert/confirm 
dialogs.

Comment 2

[Daniel Veditz [:dveditz]]

Over to mister dialog man

Comment 3

[Daniel Veditz [:dveditz]]

Moz 0.9 tasks

Comment 4

[dbragg]

p4 tasks

Comment 5

[dbragg]

We used to be able to pass nsnull as the title and basically have no title.
This is no longer the case.  The fix is to either pass a title which would
require a change to the nsInstall::Alert and nsInstall::Confirm and their
related nsJSInstall apis or to just translate the words "Alert" and "Confirm"
for the titles.  I've decided to do the latter and will post the diff.

Comment 6

[dbragg]

Attachment: Patch of nsInstall.cpp. nsInstall::Alert and ::Confirm changed

Comment 7

[Samir Gehani]

r=sgehani

Comment 8

[Scott MacGregor]

sr=mscott

Comment 9

[dbragg]

Fix checked in.  We now get the words Alert and Confirm on the title bar.
(These should up in the correct language)

Comment 10

[Jimmy Lee]

Build: 2001-03-01-11-Mtrunk(WIN), 2001-03-01-09-trunk(MAC), 
2001-03-01-08-Mtrunk(LINUX)

Looking good!  Marking Verified!