56137 - Some widgets don't fire oncommand when toggled via keys

Status: RESOLVED FIXED

(Core :: DOM: UI Events & Focus Handling, defect, P3)

Description

[Blake Ross]

Overview Description:

  oncommand doesn't seem to fire for keypresses, as evidenced by many examples 
in various pref panes.

Steps to Reproduce:
  1) Open the preferences dialog.
  2) Mail and Newsgroups > Address Books
  3) Click "Enable Email Address Collection"
  4) Press spacebar multiple times.
  5) Advanced > Proxies
  6) Click "Direct connection to the Internet"
  7) Press the down arrow key.
  8) Click "Manual proxy configuration" (it should already be checked)

Note: Some of this may only work properly in win32/classic due to different 
platform and theme keybindings.

Actual Results:   In step 4, although the checkbox is properly checked and
                  unchecked as you keep hitting spacebar, the widgets indented
                  below it don't properly enable and disable (as they did when
                  you completed step 3).  In step 6, although the "Manual proxy
                  configuration" radio button is properly checked after
                  pressing the down arrow key, its associated textboxes 
                  (indented below it) don't properly enable and didsable (as
                  they did when you completed step 8).

Expected Results: DoEnabling() is properly called whenever the radiobutton
                  and checkbox get checked (or unchecked), so the associated
                  widgets are properly enabled and disabled upon keypress just
                  as if you clicked on them with the mouse.

Reproducibility: 100%

Occurs in new branch and trunk builds (win98se).

Additional Information:
  John, should either case be valid?  I was under the impression that oncommand 
should include both mouse and keyboard commands.  In the case of step 7, 
though, the keypress is actually going to the top radio button, not the button 
that will become checked.  What do you think about all this?

Comment 1

[Blake Ross]

In case it wasn't extremely obvious, of course, the radiobutton and checkbox in 
question both have oncommand="doEnabling();"

Comment 2

[David Hyatt]

oncommand is unique to XUL, so this isn't joki's bug.  reassigning to saari.

Comment 3

[saari (gone)]

This isn't "keys don't fire oncommand", it is "some widgets don't fire oncommand
when toggled via keys".

Comment 4

[Blake Ross]

correct.

Comment 5

[saari (gone)]

mozilla 1.0

Comment 6

[Blake Ross]

*** Bug 64181 has been marked as a duplicate of this bug. ***

Comment 7

[Jesse Ruderman]

Copying from dup: access keyword, blocks bug 18575.

Comment 8

[Hixie (not reading bugmail)]

Reassigning QA Contact for all open and unverified bugs previously under Lorca's
care to Gerardo as per phone conversation this morning.

Comment 9

[Peter Trudelle]

clearing target for re-triage, nominating for moz0.9.2. Chris, do you know how 
much work/risk this would entail?

Comment 10

[saari (gone)]

Well, have to figure out which widgets don't fire it and copy and paste the code
from those that do. It shouldn't be hard.

Comment 11

[Chad Austin]

When you use the arrow keys to move around in a groupbox, the focused 
item should change just as the selected item does.

In radio.xml, I tried to do this.focusedItem = groupElements[index], but it 
didn't seem to change the focus.

I imagine this could easily be fixed when the oncommand stuff is fixed (maybe 
they're related).  If they're not related, I can file a new bug.

Comment 12

[Chad Austin]

Attachment: XBL patch

Comment 13

[Madhur Bhatia]

QA contact updated

Comment 14

[Blake Ross]

Fix is in bug 83614.

Comment 15

[Blake Ross]

Fix checked in.

Comment 16

[luis rincon]

verified on build 2001-07-13-07-trunk

Comment 17

[[e-mail]]

Reopening because I'm seeing 2 command events pressing space on a checkbox.
I think that the diff for 1.3 of checkbox.xml should be backed out.
http://www.nrr.co.uk/checkbox.xul is my test case.
[e-mail] on #mozilla agreed that pressing space dumps 2 "Ouch!"es.

Comment 18

[Asa Dotzler [:asa]]

->0.9.6

Comment 19

[Blake Ross]

File a new bug.