Closed Bug 56212 Opened 25 years ago Closed 25 years ago

Double quoted text in outgoing mail is mangled

Categories

(Core :: DOM: Editor, defect, P1)

defect

Tracking

()

VERIFIED FIXED
mozilla0.6

People

(Reporter: phil, Assigned: jst)

References

Details

(Keywords: regression, Whiteboard: [rtm++])

Using 2000-10-11-08 RTM branch build on NT 1. Open HTML mail compose window, and address to yourself 2. type "test" (with the quotes) in the body and send Message contents: <html><head></head><body>&amp;quot;test&amp;quot;<br> </body></html> Which is displayed in the mail reader as: &quot;double&quot; I'm guessing this is an editor output bug, so assigning to akkana
add regression and rtm keywords
Keywords: regression, rtm
Phil: did you really type this: &quot;double&quot; or did Mozilla do more extra mangling here as well? If so, then we have a problem in textareas.
cc jst. rtm+ing, because this breaks mail, and (by the looks of it) textareas.
Whiteboard: [rtm+]
This is easy to reproduce in the editor: type "hello" then do Output HTML. The problem is only with quotes. Other entities, e.g. <, are handled okay, but previously we output quotes without entity encoding, and now apparently we're encoding quotes, and mail can't handle it. We don't need to encode quotes (it's a legal character in an html file) and it makes the html src harder to read, so we should stop doing it.
Status: NEW → ASSIGNED
> Phil: did you really type this: > &quot;double&quot; Actually, I copied and pasted what was shown in the mail reader when receiving that message, which was exactly those characters.
Johnny says he'll take this along with other entity fixes he's already working on in his tree.
Assignee: akkana → jst
Status: ASSIGNED → NEW
What Akk said. mozITXTToHTMLConv::ScanTXT (used for URL recognition) does not expect any entities other than those for <>&. Everything else will be escaped. (This is well-doocumented.)
> ScanTXT (used for URL recognition) eh, ScanHTML (used for URL recognition at sendind time)
We would really like to see the patch and review/super review really really really soon now...
Whiteboard: [rtm+] → [rtm need info]
Marking rtm++ per discussion with jar. I have sr= & r= and I'm about to check in the fix.
Status: NEW → ASSIGNED
OS: Windows NT → All
Priority: P3 → P1
Hardware: PC → All
Whiteboard: [rtm need info] → [rtm++]
Target Milestone: --- → mozilla0.6
Fixed.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
puh! I'm very glad this fix made it into N6.
*** Bug 56454 has been marked as a duplicate of this bug. ***
verified on 10/19 branch build.
Status: RESOLVED → VERIFIED
Keywords: vtrunk
oops reopening to verify on trunk.
Status: VERIFIED → REOPENED
Resolution: FIXED → ---
Should still be fixed on the trunk, marking so...
Status: REOPENED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
marking verified.
Status: RESOLVED → VERIFIED
Removing vtrunk keyword to pull this off the needs verifying on trunk radar (and because these keywords will go away soon)
Keywords: vtrunk
You need to log in before you can comment on or make changes to this bug.