56534 - Case where Context menu "Open in new message window" fails

Status: VERIFIED FIXED

(SeaMonkey :: MailNews: Message Display, defect, P3)

Description

[pmock]

Build Date & Platform Bug Found: 
 win32 commercial seamonkey build 2000-101309-mn6 installed on P500 Win98 and 
P566 WinME
 linux commercial seamonkey build 2000-101211-mn6 installed on P200 RedHat 6.2
 macos commercial seamonkey build 2000-101110-mn6 installed on G3/400 OS 9.04

Overview Description: 
 If you have not viewed a mail message in the message pane AND have the message 
pane closed, the context menu "open in new message window" fails.  On linux 
terminal window, it report the error 
"javascript error: 
 chrome://messenger/content/mailWindowsOverlay.js line 546: message has no 
properties"

On Mac and Windows, there is no visual error message. 

When you use the File menu option "Open message", you receive a mail message ...
" *Call to xpconnect wrapped JSObject produced this error: *
[Exception... "[JavaScript Error: "message has no propertie* Call to 
xpconnect wrapped JSObject produced this error: *
[Exception... "[JavaScript Error: "message has no properties" 
{file: "chrome://messenger/content/mailWindowOverlay.js&quot ; line:546}] 
[nsIController::doCommand]" nsresult: "0x80570021 
(NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)" location: "JS frame :: 
chrome://global/content/globalOverlay.js :: goDoCommand :: line 73" data: 
yes]"

To Work around: Press Enter to open message in message window.  or double click 
on message thread to open in message window.  

To solve problem for this mail session: Load a mail message in the message pane 
then afterward the context menu "open in new message window" will work.

Steps to Reproduce: 
1) Close the message pane.
2) Exit seamonkey
3) Launch seamonkey
4) Open Mail
5) Log into mail
   I was using IMAP 
   The message pane should be closed.
6) Select a message and right click to bring up the context menu
7) Choose "open in new message window"
   Nothing happens on mac and window.
   On Linux, you see a javascript error message in the terminal window2.

Actual Results: 
On Linux, javascript error occurs.  On Mac and Windows, nothing happens 
visually.

Expected Results: 
The message should open into a new message window when using the context menu 
"open in new message window"

Additional Information:
This problem is reproducible on all platform.  I normally have the message pane 
closed because my portable can only run 800x600 resolution.  I don't have enough 
window space to keep the message pane open and I don't to like to have message 
automatically load.

Recommendation: It's not a beta++ bug but I think it a release not candidate.

Comment 1

[pmock]

Adding keyword relnoteRTM

Comment 2

[scottputterman]

reassigning to me.

Comment 3

[Scott MacGregor]

changing component to front end. 

Comment 4

[Peter "jag" Annema]

Attachment: [patch] Make "Open in new window" for closer messagepanel

Comment 5

[Peter "jag" Annema]

This fixes it for me.

Comment 6

[scottputterman]

thanks jag.  This seems good to me but I don't have a build to try it on. 
Reassigning to racham for review.

Comment 7

[racham]

Let me test the the patch and update the bug. 

Comment 8

[(not reading, please use [e-mail] instead)]

sr=sspitzer on that patch.  thanks jag.

Comment 9

[(not reading, please use [e-mail] instead)]

jag / racham, any other places where we shouldn't be using GetLoadedMessage()?

Comment 10

[Peter "jag" Annema]

No, other uses look okay...

Will check this in as soon as I get r=racham.

Comment 11

[racham]

r=racham

Comment 12

[racham]

Tested the patch with the tree updated this morning. Works fine.

Comment 13

[Peter "jag" Annema]

Taking bug.

Comment 14

[Peter "jag" Annema]

Checked in, marking fixed.

Comment 15

[[e-mail] (gone - use [e-mail] instead)]

VERIFIED FIXED.  Windows 2000 (build 2001021304), Mac (build 2001021304) and
Linux (build 2001021308), all open the message when the message pane is closed
by doing either a File | Open Message or context clicking and selecting, "Open
Message in a new window."