56635 - ">>>> Writing to clipboard" must be stopped!

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Mike Shaver (:shaver emeritus)]

I'm about to attach a patch.  Need r= and sr=.

Comment 1

[Mike Shaver (:shaver emeritus)]

Attachment: sweet, blessed silence

Comment 2

[Mike Shaver (:shaver emeritus)]

Attachment: um, sweet, blessed silence that compiles

Comment 3

[Akkana Peck]

Hey!  Please get my name out of those DEBUG_ statements!  I want to see these go
away too, and I had nothing to do with putting them there.  Pavlov might
conceivably want them.

Comment 4

[Akkana Peck]

Re review: I'd nitpick that in two cases there's no need for the else clause to
be there at all, and it would be better to put the ifdefs around the whole else
clause rather than inserting braces and ifdefing the contents of the braces. 
But that is a nit, and any reasonable compiler will make them equivalent.

Other than that, r=akkana if you remove my name from the DEBUG_clipboard
definition.

Comment 5

[Mike Shaver (:shaver emeritus)]

I thought you commented on IRC to the effect that you found them useful.  I
didn't mean to malign you!

I'll take your name out, but I don't like #ifdef around complete else clauses,
so I resist that change.  Unless someone insists, I'll not bother to repost the
patch sans-akkana.

Comment 6

[Akkana Peck]

No, don't repost it.  Yes, I found it occasionally helpful, but not so much that
I want to see it every single time the clipboard contents change ... I'll flip
it on locally if I want to debug clipboard stuff. :-)   As for the ifdef around
else, it's your choice, and I certainly don't insist on that for the r=akk.

Sure would be nice if we could turn this off for rtm!  Sigh.

Comment 7

[Mike Pinkerton (not reading bugmail)]

personally, i think this is good since it has already caught all sorts of
problems on linux with overzealous hitting of the clipboard, but i agree it
should not be a naked printf.

I'd like to see it #ifdef DEBUG, but i'll settle for DEBUG_clipboard if it's
what the masses insist upon.

Comment 8

[Mike Pinkerton (not reading bugmail)]

fixed