56883 - ECMA conformance: Array.prototype.toLocaleString()

Status: VERIFIED FIXED

(Rhino Graveyard :: Core, defect, P3)

Description

[David Flanagan]

The latest rhinoTip does not conform to ECMA v3 15.4.4.3:
it does not define Array.prototype.toLocaleString

Comment 1

[Patrick C. Beard]

Doesn't fixing #56879 trivially fix this?

Comment 2

[Norris Boyd]

No, fixing 56879 doesn't trivially fix this. Here's a test case that shows the 
way it should work.

js> x = { toLocaleString: function() { count++ } }
[object Object]
js> count =0
0
js> a = [x,x,x]
[object Object],[object Object],[object Object]
js> count
0
js> a.toLocaleString()
undefined,undefined,undefined
js> count
3

Comment 3

[Norris Boyd]

Fixed:

Checking in NativeArray.java;
/cvsroot/mozilla/js/rhino/org/mozilla/javascript/NativeArray.java,v  <--  Native
Array.java
new revision: 1.10; previous revision: 1.9
done

Comment 4

[Phil Schwartau]

Verified on Linux and WinNT using trunk build of Rhino 2000-10-25; 
method of verficiation the same as in bug 56884 -

Comment 5

[Phil Schwartau]

NOTE: also passed Norris' test case described above at 2000-10-23 07:30.
Will add to the test suite -

Comment 6

[Phil Schwartau]

Norris' testcase has been added to JS test suite as follows: 

              js/tests/ecma_3/Array/15.4.4.3-1.js