57178 - xp filepicker scrollbar hidden when dir menulist very wide

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Pete Collins (MDG)]

Using the file picker, i loose scrollbars when i start getting deep into my dir
tree.

They come back if i resize the FP window to the width of the dir tree string
displayed.
This is on the branch.

--pete

Comment 1

[Peter Trudelle]

don't see this on Linux - How deep?  ->future

Comment 2

[Peter "jag" Annema]

I'm seeing this on linux.

Do a ln -s . someveryveryverylongname, then go into that dir a few (5 or so) times.
What happens is that the dir select menulist at the top resizes and the tree
resizes with it. The right side goes out of view, thus hiding the scrollbar.

Suggested solutions:
1) make this menulist use an ellipsis at the beginning instead of resizing
2) resize the whole window along with the rest

Comment 3

[Peter "jag" Annema]

cc'ing some people, updating summary.

Comment 4

[Peter Trudelle]

Thanks Jag, but I think 'future' is the right place for this.

Comment 5

[Pete Collins (MDG)]

Attachment: image

Comment 6

[Peter Trudelle]

->bryner

Comment 7

[Brian Ryner (not reading)]

mozilla 0.9, doesn't sound too hard to fix

Comment 8

[Peter "jag" Annema]

Nope.

Ben suggested something like adding ``crop="left"'' to the menulist should do
the trick, except it currently doesn't. Either we need to add flex attribs in
places I haven't discovered yet, or there's a bug.

Comment 9

[Brian Ryner (not reading)]

Attachment: patch

Comment 10

[Brian Ryner (not reading)]

ok, we have a fix.  In addition to adding crop=left for the menulist, there was
a bug in the modern skin's XBL binding for menulist- flex=1 is needed on the
xul:text element in order for cropping to work properly.

ben, hewitt, can you review this?

Comment 11

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Comment 12

[David Hyatt]

r=hyatt

Comment 13

[Brian Ryner (not reading)]

checked in