57495 - getElementsByTagName() with uppercase parameter broken

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[dannyg]

I'm filing this as a new bug since my comment in a related bug (56257) hasn't
raised any flags. This is a serious one:

Invoking getElementsByTagName() from any node _other_ than the root #document
node has changed between M17 and M18 to require all lowercase tag name parameters.

Try it on this page. In the Address field enter:

javascript:void alert(document.body.getElementsByTagName("FORM").length)

Result is zip, zero, nada. Now enter:

javascript:void alert(document.body.getElementsByTagName("form").length)

and you get the two forms in this page. Since the Element.tagName property
returns tag names in all uppercase, and since IE and PR2 work with all uppercase
parameters to this method, this needs to be fixed pronto. All of my
developmental XML scripts no longer work in NN6.

Comment 1

[Johnny Stenback (:jst)]

This is indeed a bug in mozilla, however, since you're talking about XML scripts
I get a bit confused. Everything is and should be case sensitive in XML
documents, including XHTML documents, so I don't see how this bug could cause
problems in XML files, especially not in XHTML files where everything is lowercase?

I'll attach a patch that fixes this, and nominating for rtm.

Comment 2

[Johnny Stenback (:jst)]

Attachment: Proposed fix

Comment 3

[dannyg]

They're not XML scripts per se, but rather scripts that work with XML elements
embedded within an HTML document. IOW, stuffing some XML from a database into an
HTML document, and then using JavaScript on the client to convert the data into
convenient arrays of objects to facilitate sorting (etc.) to go beyond XSLT.

Thanks for seeing to this one.

Comment 4

[Nisheeth Ranjan]

r=nisheeth.

Comment 5

[Nisheeth Ranjan]

Marking rtm need info while jst gets a super review for his fix.

Comment 6

[Johnny Stenback (:jst)]

I just realized (while talking to Vidur about this) that the attached patch
makes it impossible to find upper-case elements within an XHTML element, I'll
attach a new patch that fixes that.

Comment 7

[Johnny Stenback (:jst)]

Attachment: New XHTML safe fix

Comment 8

[Johnny Stenback (:jst)]

Attachment: New XHTML safe fix without some unnecessary cleanup

Comment 9

[Johnny Stenback (:jst)]

Attachment: Final XHTML safe fix, I'm done now, really

Comment 10

[Eric Pollmann]

r=pollmann.  This is an extremely low risk fix.

Comment 11

[vidur (gone)]

sr=vidur. The fix looks pretty good. Since we're going from having strong case
requirements for the tagname parameter to weaker case requirements, I feel
pretty good about this.

Comment 12

[Johnny Stenback (:jst)]

Marking rtm+, hoping to get this marked as a limbo bug...

Comment 13

[Jim Roskind]

Please land this on the trunk asap to get some back time, while we keep this in
limbo for the N 6 branch.

Comment 14

[Johnny Stenback (:jst)]

Thank you, the fix is now checked into the trunk.

Comment 15

[Phil Peterson]

This bug is in candidate limbo.  We will reconsider this fix once we have a
candidate in hand, but we can't take this fix before then.

Comment 16

[selmer (gone)]

PDT marking [rtm++]. This bug is now out of limbo and approved for checkin to
the branch. Please check in ASAP.

Comment 17

[Johnny Stenback (:jst)]

Fix checked into the branch, marking FIXED.

Comment 18

[Peter Trudelle]

I now get the inverse result ("FORM" yields '2', "form" nada) using the 10-31-14
MN6 candidate build on Win98.  Is that correct? If so, consider verified on one
platform.

Comment 19

[Kathleen :Brade]

using the ns6 build from 2000103114 on Macintosh, I now get 2 for each dialog
(unlike Peter).

Comment 20

[Nisheeth Ranjan]

I just tried this on NT using the 10-30-14 branch builds and I got 2 for both
"FORM" and "form".  Marking with the vtrunk keyword, so that this bug is also
verified on the trunk.

Comment 21

[Jan Carpenter]

verified: 
2000-11-06-09-MN6 : win32 
2000-11-06-09-MN6 : linux
2000-11-06-08-MN6 : mac 
2000-11-07-08-Mtrunk : linux


Locks up the browser on these trunk builds:
2000-11-07-08-Mtrunk : win32
2000-11-07-08-Mtrunk : mac
 

Comment 22

[Prashant Desale]

QA contact Update

Comment 23

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 24

[Sivakiran Tummala]

verified