Closed Bug 574955 Opened 14 years ago Closed 9 years ago

Make webconsole work in SeaMonkey

Categories

(SeaMonkey :: UI Design, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED DUPLICATE of bug 1223341

People

(Reporter: kairo, Assigned: backburner)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file, 11 obsolete files)

697.62 KB, patch
Details | Diff | Splinter Review
The "Heads Up Display" console as introduced in bug 534398 is completely implemented in toolkit, so it should be quite easy to get it integrated in SeaMonkey.
Depends on: 568647
Version: unspecified → Trunk
the HUD is a moving target, and currently relies on many Firefox-only features [not that we can't port them], but given its dynamic and fast-paced iterations at the moment, probably not the best to devote a resources to this problem, we can re-visit for next cycle.
Summary: Make HUD console work in SeaMonkey → Make webconsole work in SeaMonkey
Depends on: 739965
No longer depends on: 739965
Attachment #613573 - Flags: feedback?(philip.chee)
Comment on attachment 613573 [details] [diff] [review]
Make Webconsole work in SeaMonkey (WIP-1)

diff --git a/suite/themes/classic/navigator/webconsole.css b/suite/themes/classic/navigator/webconsole.css
new file mode 100644
--- /dev/null
+++ b/suite/themes/classic/navigator/webconsole.css
.
.
.

+.hud-splitter {
+  border-bottom: solid #a5a5a5 1px;
+  background: url("chrome://global/skin/splitter/dimple.png") no-repeat center,
+    -moz-linear-gradient(top, #fcfcfc, #dfdfdf);
+}


Hmm, did you accidentally used the mac file here too (I happen to know that here is no dimple.png is winstripe)?
> +XPCOMUtils.defineLazyGetter(this, "HUDConsoleUI", function () {
> +  Components.utils.import("resource://gre/modules/HUDService.jsm");
What happened to the |tempScope = {}|?
Some comments Part 1 (more to come later):

> +// devtools preferences for HUDService

Please sync the comments from browser/app/profile/firefox.js
You also need:
pref("devtools.hud.loglimit.network", 200);
pref("devtools.hud.loglimit.cssparser", 200);
pref("devtools.hud.loglimit.exception", 200);
pref("devtools.hud.loglimit.console", 200);

> +<?xml-stylesheet href="chrome://navigator/skin/webconsole.css" type="text/css"?>

You might also need to copy/adapt:
chrome://browser/skin/devtools/common.css
See the current firefox browser.xul

> +  <key id="key_webConsole" key="&webConsoleCmd.commandkey;"
> +       oncommand="HUDConsoleUI.toggleHUD();"

create a command and use it instead of oncommand:
<command id="Tools:WebConsole" oncommand="HUDConsoleUI.toggleHUD();"/>
Also the Firefox onpopupshowing needs to go somewhere:
function onWebDeveloperMenuShowing() {
  document.getElementById("Tools:WebConsole").setAttribute("checked", HUDConsoleUI.getOpenHUD() != null);
}

Our popup is in tasksOverlay.xul and our popup is <menupopup id="toolsPopup">
So our function probably might be something like onToolsPopupShowing()

>  modifiers="accel,shift"/>
Mac is "accel,alt"

> +              <menuitem id="webConsole" label="&webConsoleCmd.label;"
> +                        accesskey="&webConsoleCmd.accesskey;"
> +                        key="key_webConsole" oncommand="HUDConsoleUI.toggleHUD();"/>

                  <menuitem id="webConsole"
                            type="checkbox" <<---
                            label="&webConsoleCmd.label;"
                            accesskey="&webConsoleCmd.accesskey;"
                            key="key_webConsole"
                            command="Tools:WebConsole"/> <<---

Use type="checkbox".

> +++ b/suite/modules/Makefile.in
>  
>  EXTRA_PP_JS_MODULES = \
>    Sanitizer.jsm \
> +  webconsole/HUDService.jsm \
> +  webconsole/NetworkHelper.jsm \

Only HUDService.jsm needs to be preprocessed and you can get remove the need by changing:

> #ifdef XP_MACOSX
>     this.makeCloseButton(toolbar);
> #endif

To:

> if (/Mac/.test(navigator.platform))
>     this.makeCloseButton(toolbar);

Or even moving the test into makeCloseBt

> if (/Mac/.test(navigator.platform))
>   return;

> +  webconsole/CssRuleView.jsm \
> +  webconsole/Templater.jsm \
> +  webconsole/scratchpad-manager.jsm \

Consider moving these into a new directory modules/devtools/
In Firefox these seem to be shared with the other Firefox devtools.

> chrome://navigator/skin/webconsole.png
You reference this several times but the PNG doesn't exist in your patch.
Adding this makes the toolbar buttons look better.

> +.webconsole-filter-button {
> +  border-radius: 10000px;

Remove the border-radius. Firefox got rid of this.

> +  skin/classic/navigator/gcli.css                                       (navigator/gcli.css)
> +  skin/classic/navigator/webconsole.css                                 (navigator/webconsole.css)

Consider syncing the latest changes from Firefox (later).

HUDService.jsm:
> +  if (appName() == "FIREFOX" || appName() == "SEAMONKEY") {
Just |if (appName() == "SEAMONKEY")| please.

CssRuleView.jsm:
A couple of trailing blank spaces.
Also consider syncing with the current firefox CssRuleView.jsm (later)
(In reply to Stefan [:stefanh] from comment #3)
> Comment on attachment 613573 [details] [diff] [review]
> Make Webconsole work in SeaMonkey (WIP-1)
> 
> diff --git a/suite/themes/classic/navigator/webconsole.css
> b/suite/themes/classic/navigator/webconsole.css
> new file mode 100644
> --- /dev/null
> +++ b/suite/themes/classic/navigator/webconsole.css
> .
> .
> .
> 
> +.hud-splitter {
> +  border-bottom: solid #a5a5a5 1px;
> +  background: url("chrome://global/skin/splitter/dimple.png") no-repeat
> center,
> +    -moz-linear-gradient(top, #fcfcfc, #dfdfdf);
> +}
> 
> 
> Hmm, did you accidentally used the mac file here too (I happen to know that
> here is no dimple.png is winstripe)?
Yeah. I think while copying webconsole.css, I probably used the mac version
and copied it to classic and modern.  Probably should have used the qute 
version instead.
Attached patch WIP-1a fix issues in classic (obsolete) — Splinter Review
Some fixes for classic.
Comment on attachment 614389 [details] [diff] [review]
WIP-1a fix issues in classic

> create a command and use it instead of oncommand:
I've changed my mind. Firefox uses this because they have two menu items to call the webconsole. No need to use <command>

> <command id="Tools:WebConsole" oncommand="HUDConsoleUI.toggleHUD();"/>
> Also the Firefox onpopupshowing needs to go somewhere:
> function onWebDeveloperMenuShowing() {
>   document.getElementById("Tools:WebConsole").setAttribute("checked", HUDConsoleUI.getOpenHUD() != null);

Use this instead:
document.getElementById("webConsole").setAttribute("checked", HUDConsoleUI.getOpenHUD() != null);

> }
> 
> Our popup is in tasksOverlay.xul and our popup is <menupopup id="toolsPopup">
> So our function probably might be something like onToolsPopupShowing()

> +XPCOMUtils.defineLazyGetter(this, "HUDConsoleUI", function () {
> +  Components.utils.import("resource:///modules/HUDService.jsm");
This should be in resource:///modules/ and not resource://gre/modules/

> +    let toolbar = this.makeXULNode("toolbar");
> +    toolbar.setAttribute("class", "hud-console-filter-toolbar");
> +    toolbar.setAttribute("mode", "full");

Add a few Suite Specific attributes. This will simplify the CSS:
> +    toolbar.setAttribute("xpfe", "false");
> +    toolbar.setAttribute("iconsize", "small");
> +    toolbar.setAttribute("labelalign", "end");

Get rid of preprocessing:
> +    if ("nsILocalFileMac" in Components.interfaces) {
> +      this.makeCloseButton(toolbar);
> +    }
> +
> +    for (let i = 0; i < BUTTONS.length; i++) {
> +      this.makeFilterButton(toolbar, BUTTONS[i]);
> +    }
> +
> +    toolbar.appendChild(this.filterSpacer);
> +
> +    let positionUI = this.createPositionUI();
> +    toolbar.appendChild(positionUI);
> +
> +    toolbar.appendChild(this.filterBox);
> +    this.makeClearConsoleButton(toolbar);

Get rid of preprocessing:
> +    if (!("nsILocalFileMac" in Components.interfaces)) {
> +      this.makeCloseButton(toolbar);
> +    }

Add a few more Suite Specific attributes:
> +    toolbarButton.classList.add("toolbarbutton-1");

You missed this:
> +  skin/classic/navigator/webconsole.png                                (navigator/webconsole.png)

etc.
> diff --git a/suite/themes/classic/mac/navigator/webconsole.png b/suite/themes/classic/mac/navigator/webconsole.png
> new file mode 100644

> +.webconsole-filter-button {
> +  border-radius: 10000px; <- removed Firefox doesn't use this any more.
> +  -moz-margin-start: 6px;
> +  -moz-box-orient: horizontal; <- Handled by suite CSS (labelalign="end")

Use navigator styles/images:
> +.webconsole-close-button {
> +  list-style-image: url("chrome://communicator/skin/icons/close-button.gif");
> +  margin: 3px;
> +}
Maybe we should put the icons in navigator/icons/ ?
This fixes most of the problems in the filter buttons styles in Classic (but not Classic/Mac) and goes some of the way in Modern.
Attachment #614389 - Attachment is obsolete: true
> Maybe we should put the icons in navigator/icons/ ?
Oops yeah.
Assignee: nobody → ewong
Attachment #613573 - Attachment is obsolete: true
Attachment #614764 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Attachment #615173 - Flags: feedback?(philip.chee)
Attachment #613573 - Flags: feedback?(philip.chee)
Comment on attachment 615173 [details] [diff] [review]
Make Webconsole work in SeaMonkey. (WIP-2)

Some comments based on code inspection. More later:

> +  var webConsoleItem = document.getElementById("webConsole");
> +  
> +  webConsoleItem.setAttribute("checked", HUDConsoleUI.getOpenHUD() != null);

document.getElementById("webConsole")
        .setAttribute("checked", HUDConsoleUI.getOpenHUD());

>  EXTRA_PP_JS_MODULES = \
>    Sanitizer.jsm \
> +  webconsole/HUDService.jsm \
Move the webconsole JSMs to  EXTRA_JS_MODULES.

[HUDService.jsm]
> +    if (appName() == "FIREFOX" || appName() == "SEAMONKEY") {
AppName() will never be FIREFOX.

> +  makeCloseButton: function HUD_makeCloseButton(aToolbar)
> +  {
> +
Extra blank line not needed.

> +  nodeChanged: function CssRuleView_nodeChanged()
> +  {
> +    this._clearRules();
> +    this._elementStyle.populate();
> +    this._createEditors();
> +  },   
.......^^ Two trailing spaces here.

[classic->glci.css]
> +/* From: $GCLI/mozilla/gcli/ui/gcliterm-pinstripe.css */
That's -winstripe.css not -pinstripe.css

> +.gcliterm-input-node,
> +.gcliterm-complete-node {
> +  font: 11px Menlo, Monaco, monospace;
> +}

Winstripe uses:
font: 12px Consolas, "Lucida Console", monospace;

> +.gcliterm-complete-node {
> +  padding-top: 6px !important;
> +}

You must have copied these from pinstripe, winstripe doesn't have these.

> +.gcli-out-shortcut {
> +  font-family: Menlo, Monaco, monospace;

Winstripe uses:
font-family: Consolas, Inconsolata, "Courier New", monospace;

[classic->webconsole.css]

> +.webconsole-close-button {
> +  list-style-image: url("chrome://global/skin/icons/close.gif");

Should be: chrome://communicator/skin/icons/close-button.gif

> +  -moz-image-region: rect(0, 16px, 16px, 0);
Remove this -moz-image-region. The .gif file has only one image.

> +}
> +
> +.webconsole-close-button:hover {
> +  -moz-image-region: rect(0, 32px, 16px, 16px);
> +}
> +
> +.webconsole-close-button:hover:active {
> +  -moz-image-region: rect(0, 48px, 16px, 32px);
> +} 
Drop these styles. Our default theme doesn't use different icons for hover/active. And -moz-image-region doesn't work here anyway.

> +.jsterm-input-node {
> +  background: url("chrome://navigator/skin/commandline.png") 4px 3px no-repeat;
> +}

You moved these to /icons/ so the url should be:
"chrome://navigator/skin/icons/commandline.png"
Strangely you got it correct in modern.


> +.toolbarbutton-text {
> +  display: inline;
> +  padding-left: 5px;
> +}
This is wrong as it affects all toolbar buttons in navigator.css instead of just the webconsole. :P
Also I know you said you need this but I think the problem needs to be fixed some other way.

[modern->webconsole.css]
> +.hud-console-filter-toolbar {
> +  padding: 1px 2px;
> +  -moz-box-align: center;
> +  -moz-appearance: none;
> +  border-top: none;
> +  background-color: transparent;
> +}

Remind me again why you need the background-colo(u)r to be transparent?

> +.toolbarbutton-text {
> +  display: inline;
> +}
Again this is wrong.
Attachment #615173 - Attachment is obsolete: true
Attachment #616004 - Flags: feedback?(philip.chee)
Attachment #615173 - Flags: feedback?(philip.chee)
classic->gcli.css

> +.gcli-out-shortcut {
> +  font-family: Consolas,  Inconsolata, "Courier New", monospace;
Extra space before Inconsolata.
> +}

modern->gcli.css
You seem to have copied this from pinstripe and not winstripe?

Your .toolbarbutton-text problem is due to tabbrowser.css having these rules:

> .toolbarbutton-text {
>   display: none;
> }
> 
> .toolbarbutton-icon {
>   margin: 0px !important; /* needs to override communicator.css */
> }

I've attached an incremental patch that fixes the problem in a more elegant way. You need to apply it on top of your WIP-3 and then qfold this into WIP-3
What is does is the following:

HUDService.jsm:

> +    let button = this.makeXULNode("toolbarbutton");
> +    button.setAttribute("type", "menu");
> +    button.setAttribute("label", this.getStr("webConsolePosition"));
> +    button.setAttribute("tooltip", this.getStr("webConsolePositionTooltip"));

> +    button.classList.add("toolbarbutton-1");
Change "toolbarbutton-1" to "webconsole-button"
e.g. button.classList.add("webconsole-button");

> +    toolbarButton.classList.add("webconsole-filter-button");
> +    toolbarButton.classList.add("toolbarbutton-1");
Change "toolbarbutton-1" to "webconsole-button"
e.g. toolbarButton.classList.add("webconsole-button");

> +    let clearButton = this.makeXULNode("toolbarbutton");
> +    clearButton.setAttribute("label", this.getStr("btnClear"));
> +    clearButton.classList.add("webconsole-clear-console-button");
Add:
    clearButton.classList.add("webconsole-button");

Then in webconsole.css:

Remove the styles you added:
> +.webconsole-clear-console-button > .toolbarbutton-text {
> +  display: inline;
> +  background-color: transparent;
> +}

And:
> +.toolbarbutton-menubutton-button > .toolbarbutton-text {
> +	display: inline;
> +	background-color: transparent;
> +	padding-left: 5px;
> +}
> +
> +.toolbarbutton-1 .toolbarbutton-text {
> +	display: inline;
> +	background-color: transparent;
> +	padding-right: 5px;
> +}
(you have some \t abs here as well)

And then add the following at the end of the file:

.webconsole-button > .toolbarbutton-text,
.webconsole-button > .toolbarbutton-menubutton-button > .toolbarbutton-text,
.webconsole-button > hbox > vbox > .toolbarbutton-text {
  display: -moz-box;
}

.webconsole-button > .toolbarbutton-menubutton-button > .toolbarbutton-icon {

  -moz-margin-end: 5px !important;

}

See attached incremental patch.
Attachment #616004 - Flags: feedback?(philip.chee)
TODO:
Classic: replace hard coded colors e.g. #FFF with System colours e.g. white.
(Ask Neil for suggestions)
Classic Mac: As Stefan for ui-review and colour suggestions.
Modern: replace System colours with hard coded colours.
Submitting for Mac ui-review
Attachment #616004 - Attachment is obsolete: true
Attachment #620009 - Attachment is obsolete: true
Attachment #621300 - Flags: ui-review?(stefanh)
ui-review for Mac
Attachment #621300 - Attachment is obsolete: true
Attachment #621310 - Flags: ui-review?(stefanh)
Attachment #621300 - Flags: ui-review?(stefanh)
> var mixins = new SeaMonkeyApplicationHooks();
err I didn't mean for you to change every instance of "firefox" to "seamonkey"! I think we should leave the names untouched e.g. FirefoxApplicationHooks and only change where necessary.

> +    switch(aAppName) {
> +      case "SeaMonkey":
SEAMONKEY in CAPS!

Do something like this:
   switch(aAppName) {
     case "FIREFOX":
     case "SEAMONKEY":
ui-review for Mac
Attachment #621310 - Attachment is obsolete: true
Attachment #621370 - Flags: ui-review?(stefanh)
Attachment #621310 - Flags: ui-review?(stefanh)
Comment on attachment 621370 [details] [diff] [review]
Make Webconsole work in SeaMonkey. (WIP-4b)

(drive-by comment, will look at this later on this week)

+.webconsole-close-button {
+  list-style-image: url("chrome://communicator/skin/icons/close-button.gif");
+  margin: 3px;
+}

You should use the pinstripe close.png with its different hover states (see the original file).
Comment on attachment 621370 [details] [diff] [review]
Make Webconsole work in SeaMonkey. (WIP-4b)

   skin/classic/navigator/icons/restore.png                              (mac/navigator/icons/restore.png)
+  skin/classic/navigator/icons/webconsole.png                           (mac/navigator/webconsole.png)

Wrong path (should be mac/navigator/icons/webconsole.png)

.webconsole-filter-button,
+.webconsole-clear-console-button {
+  border: 1px solid rgba(0, 0, 0, .4);
+  background: -moz-linear-gradient(top, #FFF, #CACACA) repeat-x;
+  box-shadow: 0 1px rgba(255, 255, 255, .4);
+  color: buttontext;
+}
+
+.webconsole-filter-button {
+  -moz-margin-start: 6px;
+}
+

It looks like you miss a lot of style rules here. Right now, button labels are not even visible ;-). As a general rule, you need to port everything - not just some style rules. See below for what the browser pinstripe file has.

mozilla/browser/themes/pinstripe/devtools/webconsole.css:
157 
158 .webconsole-filter-button,
159 .webconsole-clear-console-button {
160   -moz-appearance: none;
161   border: @roundButtonBorder@;
162   background: @roundButtonBackground@;
163   box-shadow: @roundButtonShadow@;
164   color: buttontext;
165   margin: 1px 0;
166   padding: 0;
167 }
168 
169 .webconsole-filter-button {
170   border-radius: 10000px;
171   -moz-margin-start: 6px;
172   -moz-box-orient: horizontal;
173 }

See also comment #21.

Since this is WIP, I think you can just fix the above mentioned issues and let me have another spin when you're done. There could be more issues, but adding/removing other things without having a mac is probably not a good idea.
Attachment #621370 - Flags: ui-review?(stefanh) → ui-review-
Comment on attachment 621370 [details] [diff] [review]
Make Webconsole work in SeaMonkey. (WIP-4b)

> +   * FireFox-specific current tab getter
> +    // TODO: the following  part is still very FireFox specific
s/FireFox/Firefox/
> +    switch(aAppName) {
> +      case "SeaMonkey":
case "SEAMONKEY":
Depends on: 756800
In Bug 756800 I'm fixing some tabbrower.css styles that intefere with the Web Console UI. This means that we can remove the workarounds I have been discussing with ewong.

This patch applies on top of (WIP-4b) and should be qfold-ed in.

> +    this._measurement.className = "autosizer";
This doesn't do anything at the moment but makes it easier to diff with Firefox.

> +/* XXXewong: TODO.
>  XPCOMUtils.defineLazyGetter(this, "ScratchpadManager", function () {
Comment out calls to scratchpad since we don't have it yet. Should be simple to add this once the Web Console is in so not removing the code at the moment. We could also remove scratchpad-manager.jsm from your patch.

> -  Cu.import("resource:///modules/GcliTiltCommands.jsm", commandExports);
We don't have tilt yet.

>      switch(aAppName) {
> -      case "FIREFOX":
> +      case "SEAMONKEY":
Oops!

> -    button.classList.add("webconsole-button");
[....]
> -
> -.webconsole-button > .toolbarbutton-text,
> -.webconsole-button > .toolbarbutton-menubutton-button > .toolbarbutton-text,
> -.webconsole-button > hbox > vbox > .toolbarbutton-text {
> -  display: -moz-box;
> -}
> -
> -.webconsole-button > .toolbarbutton-menubutton-button > .toolbarbutton-icon {
> -  -moz-margin-end: 5px !important;
> -}
Assuming that Bug 756800 is fixed we don't need these any more.

modern->gcli.css:

> -/* From: $GCLI/mozilla/gcli/ui/gcliterm-pinstripe.css */
> +/* From: $GCLI/mozilla/gcli/ui/gcliterm-winstripe.css */

Copy from winstripe instead of pinstripe.

gcli.jsm:
You missed two properties files.

>   var stringBundle = temp.Services.strings.createBundle(
>           "chrome://browser/locale/devtools/gclicommands.properties");

> XPCOMUtils.defineLazyGetter(this, 'stringBundle', function () {
>   return Services.strings.createBundle('chrome://browser/locale/devtools/gcli.properties');
> });

HUDService.jsm:

>   this.iframe = createAndAppendElement(this.panel, "iframe", {
>     src: "chrome://browser/content/NetworkPanel.xhtml",
>     type: "content",
>     flex: "1"
>   });
Probably best to comment out all references to the network panel since we don't have it yet.

>     let iframe = createAndAppendElement(panel, "iframe", {
>       src: "chrome://browser/content/devtools/cssruleview.xul",
>       flex: "1",
>     });
And this as well. We can add these two in follow-up patches.
Attachment #625429 - Flags: feedback?(ewong)
Attachment #625429 - Flags: feedback?(ewong) → feedback+
Comment on attachment 625429 [details] [diff] [review]
Patch WIP-4.1b Applies on top of WIP-4b

My bad.  Removing the webconsole toolbar stuff removes the text from 'modern' 
theme.
Attachment #625429 - Flags: feedback+ → feedback-
This patch is missing the text again.
Attachment #621370 - Attachment is obsolete: true
Attachment #625429 - Attachment is obsolete: true
Attachment #625490 - Flags: feedback?(philip.chee)
> Make Webconsole work in SeaMonkey. (WIP-5)
You need the patch from Bug 756800 as well ;)
No longer blocks: FF2SM
No longer depends on: 534398, 568647
> 169 .webconsole-filter-button {
> 170   border-radius: 10000px;
Stefanh: remind me again why 10000px is needed here?
Blocks: FF2SM
Depends on: 534398, 568647
(In reply to Philip Chee from comment #29)
> > 169 .webconsole-filter-button {
> > 170   border-radius: 10000px;
> Stefanh: remind me again why 10000px is needed here?

IIRC that's to ensure that the corners are round (http://mxr.mozilla.org/mozilla-central/search?find=%2Ftoolkit%2Fthemes%2F&string=10000px)
Blocks: 760799
Attachment #625490 - Attachment is obsolete: true
Attachment #625490 - Flags: feedback?(philip.chee)
Attachment #639603 - Flags: feedback?(philip.chee)
Thanks for working on this, I needed the Web Console a few days ago (used the FF one though), quite impressive what you can do with it :)
Assignee: ewong → backburner
It would be ideal if you actually could port the developer toolbox that they added in FF20, as that now consolidates all the dev tools in one interface and even lets you detach that as its own window.
Blocks: smdevtools
Comment on attachment 639603 [details] [diff] [review]
Make Webconsole work in SeaMonkey (WIP-6)

I'm cancelling the feedback request as this patch is now severely bit rotted. With all the refactoring the devtools team has done I think it's now much easier to implement the web browser.
Attachment #639603 - Flags: feedback?(philip.chee)
What's the status of this? Is this bug meant to integrate the whole DevTools into SeaMonkey?

Sebastian
Flags: needinfo?(philip.chee)
Flags: needinfo?(backburner)
(In reply to Sebastian Zartner [:sebo] from comment #35)
> What's the status of this? Is this bug meant to integrate the whole DevTools
> into SeaMonkey?
> 
> Sebastian

No, not the whole devtools.  Just the webconsole.
Flags: needinfo?(backburner)
(In reply to Sebastian Zartner [:sebo] from comment #35)
> What's the status of this? Is this bug meant to integrate the whole DevTools
> into SeaMonkey?

No, but if you're going to write a patch for us to integrate all of devtools into SeaMonkey, we won't say no - but best to open a new bug on that.
Flags: needinfo?(philip.chee)
Blocks: 1114519
(In reply to Philip Chee from comment #37)
> (In reply to Sebastian Zartner [:sebo] from comment #35)
> > What's the status of this? Is this bug meant to integrate the whole DevTools
> > into SeaMonkey?
> 
> No, but if you're going to write a patch for us to integrate all of devtools
> into SeaMonkey, we won't say no - but best to open a new bug on that.

I do not plan to write a patch as I am not working on or using it, though there is obviously a demand for having DevTools available within SeaMonkey. E.g. see https://groups.google.com/forum/#!msg/firebug/9nWmTvZv6lw/d_pkNjo1QBgJ.

Sebastian
(In reply to Sebastian Zartner [:sebo] from comment #38)
> I do not plan to write a patch as I am not working on or using it, though
> there is obviously a demand for having DevTools available within SeaMonkey.

I think everyone agrees on that. The problem here (and the good thing at the same time), just as with many other things in this project, is that SeaMonkey is an all-volunteer project, everyone doing work on it does so in their free time, and it's a small group of people - that said, this also means anybody can jump in and help and get things going!
So, since this is a 'moving target', will we ever have builds including the webconsole in releases? I love SeaMonkey but am not very familiar with Mozilla's and SeaMonkey's development styles and methods. Since this issue has been open for 5 years, I am wondering if I can ever expect webconsole to work in release builds.
I compile SeaMonkey myself on Linux 64 bit, but on my older windows machine I do not have enough memory to link it.

What would prevent this from being made more compatible upstream in the Firefox project? Would they allow patches that allow it to run with either SeaMonkey or Firefox?
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → DUPLICATE
No longer blocks: 760799
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: