Closed Bug 57584 Opened 25 years ago Closed 22 years ago

[FIX]Test8's button uses bad style >>> style="bg.jpg"

Categories

(Core :: Layout: Form Controls, defect, P5)

Product:
Core
Component:
Layout: Form Controls
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Future

People

(Reporter: bugzilla, Assigned: rods)

References

(
URL
)

Details

(Whiteboard: not a code level change)

At Debug > Viewer Demos > #8 Form (resource:///res/samples/test8.html) there's a button containing a table and, supposedly, a background image. But this background image doesn't render because the button has style="bg.jpg" instead of the proper style="background-image:bg.jpg". Or is style="bg.jpg" supposed to actually work for some twisted reason?
nope, that isn't supposed to work.
Whiteboard: not a code level change
Yes, this is a bug in the testcase, Yeah!
Status: NEW → ASSIGNED
Summary: Missing "background-image" for button style at Viewer Demos Test #8 → [TST]test8's button uses bad stype >>> style="bg.jpg"
Target Milestone: --- → Future
Rod, I'll check this fix in soon if you want...
Yes, please take the bug and do that, otherwise it will be a while. Thanks.
.
Assignee: rods → blakeross
Status: ASSIGNED → NEW
Status: NEW → ASSIGNED
OS: Windows 98 → All
Priority: P3 → P5
Hardware: PC → All
Summary: [TST]test8's button uses bad stype >>> style="bg.jpg" → Test8's button uses bad style >>> style="bg.jpg"
Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
Is this fixed? It looke like you reverted the checkin. If so, it should be reopened.
Yeah I did, but it turns out the tbox test is wrong, not me. But I don't want to leave tbox orange until monday, so I'll recheck this in on Monday.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Fix checked in again.
Status: REOPENED → RESOLVED
Closed: 25 years ago → 25 years ago
Resolution: --- → FIXED
Fix backed out again.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
rods, wanna take this back? Tried checking in the fix twice now, and linux and speedracer keep going orange with a SIGHUP message. Ian, cls and I can't figure it out...
Assignee: blakeross → rods
Status: REOPENED → NEW
going to get this off my radar by fixing it: Index: test8.html =================================================================== RCS file: /cvsroot/mozilla/webshell/tests/viewer/samples/test8.html,v retrieving revision 3.33 diff -u -r3.33 test8.html --- test8.html 2000/11/29 05:37:44 3.33 +++ test8.html 2001/02/07 14:34:54 @@ -36,7 +36,7 @@ </FIELDSET> <BR><BR> <div align=center><bold><font size=2>html 4 button</font></bold></div> -<BUTTON type=submit style="bg.jpg"> +<BUTTON type=submit> <font size=4><B>This button contains a table <table border=3><TR border=1><TD>CELL 1</TD><TD>CELL 2<TD></TR> <TR><TD>CELL 3</TD><TD>CELL 4</TD></TR></table>
Status: NEW → ASSIGNED
Summary: Test8's button uses bad style >>> style="bg.jpg" → [FIX]Test8's button uses bad style >>> style="bg.jpg"
Target Milestone: Future → mozilla0.9
rods: That still leaves us with a problem. When Blake fixed the problem originally, it caused orangeness. That is a potentially serious issue. Shouldn't we investigate this? Note, this patch _will_ need r= and sr= because it *is* part of the tinderbox builds (the proof of which is that checking in the original change caused tinderbox to turn orange).
Target Milestone: mozilla0.9 → mozilla0.9.1
removing the invalid "style" for an html 4 button caused the tree to go orange. How is that?
QA Contact Update
QA Contact: bsharma → vladimire
Target Milestone: mozilla0.9.1 → mozilla1.0.1
futuring
Target Milestone: mozilla1.0.1 → Future
I checked in the fix for this a few months back (see revision 3.35 at http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/webshell/tests/viewer/samples/test8.html)
Status: ASSIGNED → RESOLVED
Closed: 25 years ago → 22 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.