Closed Bug 57763 Opened 24 years ago Closed 23 years ago

"send e-mail address as anonymous ftp passwd" doesn't work

Categories

(Core Graveyard :: Networking: FTP, defect, P3)

Product:
Core Graveyard
Component:
Networking: FTP
Type:
defect

Tracking

(Not tracked)

Status:
VERIFIED FIXED
Milestone:
mozilla0.9

People

(Reporter: kazhik, Assigned: dougt)

References

Details

(Keywords: testcase)

Attachments

(2 files, 1 obsolete file)

patch to implement FE
5.11 KB, patch
Details | Diff | Splinter Review
patch; version 2; test the bool pref first and be cleaner
1.25 KB, patch
Details | Diff | Splinter Review 
"mozilla@" is always sent as ftp password even if
"send e-mail address as anonymous ftp passwd" is checked in
preferences dialog.


This bug was reported on Japanese bugzilla.
http://bugzilla.mozilla.gr.jp/show_bug.cgi?id=355
->rjc
Assignee: gagan → rjc
Target Milestone: --- → Future
setting bug status to New.  kazhik, I've updated your bugzilla permissions.  
Please email me if you have any questions.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Hi dougt, welcome to necko :)
Assignee: rjc → dougt
Blocks: 62352
My question is which email address to I send and where do I get it from? 
Suppose the user does not install mail/news, or the user has multiple email
accounts!

Ben, do you think that we can change the Advanced section of the preferences
dialog so that it includes a text field which will allow the user to specify an
email address that they would like use in the case of anonymous ftp?  

I would need this field to do some simply testing before saving it off as a pref
(eg. check to see that it is not empty when the checkbox is enabled and to check
that it does include a @ symbol).
Target Milestone: Future → mozilla0.9
dougt, sure, this sounds reasonable. file a bug on me & mark nsbeta1 if it's 
urgent and I'll hook it up shortly. 

Ben, use this one.  Assign it back to me so that I can implement the underlying
protocol to use this preference.

The pref name should be

network.ftp.anonymous_password
Assignee: dougt → ben
Keywords: nsbeta1
adding appropriate keywords.
Status: NEW → ASSIGNED
Keywords: approval, patch, review
Looks good.  You've got a tab before the <title/>, and I don't see why we can't 
just use .readonly for the textfield
(http://lxr.mozilla.org/seamonkey/source/xpfe/global/resources/content/xulBindin
gs.xml#309). r=blake otherwise
nice catches, thanks! Modified in my tree. 

Changing keyword field to just read 'approval' now, cc'ing alec. Alec, do you 
think you could super-review this?
Keywords: review
sr=alecf
we should file a new bug about mailnews setting this pref (not turning it on of
course, I just mean setting the e-mail address) when it creates it's first account.
Blocks: 64833
A concern, for the new bug Alec just asked for: if a user has used the 
functionality provided by this patch to set network.ftp.anonymous_password to 
"nobody@home.never" and then creates a Mail account for "my-primary-email
@netscape.net", he or she would be justifiably upset, from a privacy standpoint,
to see network.ftp.anonymous_password changed to the latter address. 
The new code to fill network.ftp.anonymous_password should do nothing if
it already contains an address (or even a junk string)!

oh of course! I just meant if the pref wasn't already set
forgot to mark fixed.
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Actually, this was supposed to go back to dougt for the backend.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
-> dougt
Assignee: ben → dougt
Status: REOPENED → NEW
Ben - Should I be honoring the "advanced.mailftp" preference too?  Could you
please verify this in your patch??  Could we also rename this string to
something like:  

network.ftp.send_anonymous_password

FTP now honor the password field.  However, there is a checkbox above this field
in the Advanced Prefs which is not honor nor does it dim the edit field.  

Ben, what do you want to do about this?  Either remove the checkbox (my code
will still continue to work), or make it dim the edit field, rename the pref
that it sets, and assign it back to me.
Assignee: dougt → ben
ok this is about the point where I kill bugzilla for being so brain-dead stupid. 

patch to fix disabling problem follows in this comment, because bugzilla 
wouldn't attach the patch. 

note that we still need a rule in classic at least to make disabled fields be 
greyed out. this was achieved before by setting the readonly property as well, 
but really disabled should do this too. 

Index: pref-advanced.xul
===================================================================
RCS file: 
/cvsroot/mozilla/xpfe/components/prefwindow/resources/content/pref-advanced.xul,
v
retrieving revision 1.46
diff -u -r1.46 pref-advanced.xul
--- pref-advanced.xul	2001/03/07 07:49:00	1.46
+++ pref-advanced.xul	2001/03/28 02:34:22
@@ -44,7 +44,7 @@
     {
       var checked = document.getElementById("advancedMailFTP").checked;
       var field = document.getElementById("advancedMailFTPAddress");
-      field.disabled = field.readonly = !checked;
+      field.disabled = !checked;
     }
     
   ]]>

someone can review this within three days or this gets scooted into 1.0. 
r=jag
sr=alecf
nav triage team:

Not a beta stopper, but Ben check this mutha in! Marking nsbeta1-
Keywords: nsbeta1 → nsbeta1-
boom shaka laka
Status: NEW → RESOLVED
Closed: 24 years ago → 23 years ago
Resolution: --- → FIXED
REOPENING:
FTP behavior working, but checkbox is ignored, if the field is blank, "mozilla"
is sent, if the field is populated, the contents are always sent. I traced the
ftp session on a system with anonymous FTP.

I've traced this on Win32, and will look at the other plats when this is cleared up.

Was the checkbox/grey text field patch actually checked in?

I'm verifying against Mozilla 0.9, and the feature works, but the UI patch is
not in.

I'd really appreciate it if you guys didn't more bugs over milestones.

If you move the fix into a new bug, and mark the milestone for Mozilla 0.9.1,
that would be great.
Status: RESOLVED → REOPENED
Component: Networking → Networking: FTP
Keywords: testcase
Hardware: PC → All
Resolution: FIXED → ---
I'm seeing this as well (on Linux, build ID 2001090400):

Mozilla is sending the email address set as anonymous FTP passwort
even when the checkbox is not checked in Preferences (verified in
FTP server log).

Is there a separate bug for this issue?

Well, actually the UI is doing everything correctly. [I suppose one could 
argue that when the checkbox is unchecked, the textfield should be cleared
but that would force a user who wants to occasionally enable "real email"
for ftp anon. logins to enter their email address everytime, instead of just
toggling the 'advanced.mailftp' pref that is tied to that checkbox).

The real problem is that nsFtpConnectionThread.cpp is only checking whether
'network.ftp.anonymous_password' is not empty, and not checking if 
'advanced.mailftp' is enabled. Both need to be checked. Patch coming up.

dougt, bbaetz: can I get a witness! Amen.
Assignee: ben → dougt
Status: REOPENED → NEW
... and I'll note that sending 'mozilla@' is the correct thing to do when
the checkbox is checked and the textfield is blank. Some ftp servers insist
on receiving at least a plausible email address before allowing anonymous 
login, so need to send that stub name. It's as anonymous as a blank string
(well almost).
Comment on attachment 48672 [details] [diff] [review]
patch; check advanced.mailftp is true as well; otherwise send 'mozilla@'

"advanced.mailftp"? Yuck.

you don't need rv2, either, do you?

r=bbaetz
Attachment #48672 - Flags: review+
Attachment #48672 - Attachment is obsolete: true
> "advanced.mailftp"? Yuck.

Legacy pref name, I think. Don't see much point in changing it though.

> you don't need rv2, either, do you?

Um, no. Patch take 2. Test the bool pref before even bothering getting the 
string. I also changed 'if (NS_SUCCEEDED(rv) || pPref)' to be an '&&' test
since I don't see why you would go ahead if rv was a failure (although testing
for both seems like overkill).

r=/sr=? dougt?
sr=dougt on patch 2.  John, do you want to check this in?
Thanks.

> do you want to check this in?

No can do (don't have cvs access to the main tree). Okay, I should fix that,
but for now can you or bbaetz check this in?
Status: NEW → RESOLVED
Closed: 23 years ago → 23 years ago
Resolution: --- → FIXED
Checking in nsFtpConnectionThread.cpp;
/cvsroot/mozilla/netwerk/protocol/ftp/src/nsFtpConnectionThread.cpp,v  <-- 
nsFtpConnectionThread.cpp
new revision: 1.192; previous revision: 1.191
done
QA Contact: tever → benc
No longer blocks: 64833
VERIFIED:
Mozilla 0.9.5 - all plats.

Did this not make it into the 0.9.4 trunk? This does not work in Mozilla 0.9.4 
in Mac classic.
Status: RESOLVED → VERIFIED
Hmm. Nope, this didn't go on the 0.9.4 branch. Oh, well. Too late now.
RELNOTE NS 6.2/Mozilla 0.9.4:

Configuring the Anonymous FTP password:

"Send this email address as anonymous FTP password" does not work as expected.

1- An email address is not required, any password is acceptable.
2- The checkbox is ignored. If there is anything in the password field, that
password will be used, even if the checkbox is off. 

The default value is "mozilla@example.com".
Keywords: relnote
The default value is 'mozilla@' in the branch builds (like it has been for 7 
years :-).

> 1- An email address is not required, any password is acceptable.

I wouldn't even mention that since that is true independent of the UI (although 
some small number of ftp servers may enforce at least the presence of '@').

The defect in this bug is really just point (2).
jrgm: perl.com (IIRC) insisted on user@host, so we've changed it on the trunk to
mozilla@example.com. I don't think that made the branch, though.
Yes, the mozilla@example.com change is not on the branch either, so I was just 
noting that the default password was still 'mozilla@'.
this is fixed. removing from 0.9.6 release notes
-relnote.
Keywords: relnote
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: