578437 - The HUD console fails to re-attach the window.console object after page reload.

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Mihai Sucan [:msucan]]

User-Agent:       Opera/9.80 (X11; Linux x86_64; U; fr) Presto/2.6.30 Version/10.60
Build Identifier: 

The window.console API is not available after page reload, even if the HUD console is open.

Reproducible: Always

Steps to Reproduce:
- Open a web page that uses the window.console API.
- Open the HUD console.
- Try from the web page to access window.console. It should work - the window.console API is attached when the HUD console is displayed.
- Reload the web page and try to use the window.console API again.
Actual Results:  
The window.console property is undefined.

Expected Results:  
The window.console API should be available.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: proposed fix

This fixes the issue reported. The HUDService.windowInitializer() uses the HeadsUpDisplay.console() getter when the web page is reloaded, but that getter did not return any value.

Comment 2

[David Dahl :ddahl]

If you type "console" after reloading, it is indeed available, and all of the messages that come from listeners, etc, have access to the window's console. This is related to the sandbox bug i think: bug 572953

CCing mrbkap

Comment 3

[David Dahl :ddahl]

Comment on attachment 457121 [details] [diff] [review]
proposed fix

clearly some sloppy coding on my part. Thanks!

Comment 4

[David Dahl :ddahl]

Pushed:

http://hg.mozilla.org/users/ddahl_mozilla.com/heads-up-display/rev/b60630adbb1b

Comment 5

[Rob Campbell [:rc] (:robcee)]

reopening. This isn't in mozilla-central.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 457121 [details] [diff] [review]
proposed fix

requesting review to get this fix checked in.

Comment 7

[David Dahl :ddahl]

crap. sorry about closing this bug. what was I thinking?

Comment 8

[Dave Townsend [:mossop]]

Comment on attachment 457121 [details] [diff] [review]
proposed fix

This code seems fine however I think you should add an automated test before landing

Comment 9

[Mihai Sucan [:msucan]]

Attachment: patch + test code, for mozilla-central

I have updated the patch now to include test code for the issue. This patch applies cleanly only on the mozilla-central default branch.

Comment 10

[Rob Campbell [:rc] (:robcee)]

we should let mossop review this since he did the first round.

Comment 11

[Rob Campbell [:rc] (:robcee)]

this doesn't apply cleanly and there are some contradictions in the patch and what's in browser_HUDServiceTestsAll.js.

Please fix!

Comment 12

[Mihai Sucan [:msucan]]

Attachment: [checked-in] rebased patch + test code

rebased patch for mozilla-central as of now.

Comment 13

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 458341 [details] [diff] [review]
[checked-in] rebased patch + test code

changeset:   47925:a80066930eb5
tag:         tip
user:        Mihai Sucan <[e-mail]>
date:        Mon Jul 19 12:15:21 2010 -0300
summary:     bug 578437 - The HUD console fails to re-attach the window.console object after page reload, r=mossop