5794 - [MAC]Aliasing NGLayoutConfigInclude.h to MacConfigInclude.h is evil

Status: RESOLVED FIXED

(SeaMonkey :: Build Config, defect, P3)

Description

[Simon Fraser [no longer active]]

I just lost about an hour of time with a broken build, becuase of this nasty
hack of aliasing NGLayoutConfigInclude.h to MacConfigInclude.h. I happened
to cancel the dist process half way, so failed to reach the last line
where the old MacConfigInclude.h alias is replace by the NGLayoutConfigInclude.h
one.

We need to figure out:
1. If this hack is still needed
2. Why NGLayoutConfigInclude.h exists at all. It certainly violates the
   organization of config files that I started with.
3. Whether there are any commercial build implications in any of this.

Comment 1

[Patrick C. Beard]

I agree it is evil. I lost some time on it one day as well.

Comment 2

[leger]

Putting on [PP] radar.

Comment 3

[Kevin McCluskey (gone)]

Mac specific issue. Reassigning to Don.

Comment 4

[dcone (gone)]

Waqar.. Can you look at this.. I don't understand much about this issue and you 
are closer to those who this effects.

Comment 5

[waqar]

Looking into it.

Comment 6

[Chris Yeh]

mass re-assign of all bugs where i was listed as the qa contact

Comment 7

[waqar]

This bug has been marked "future" because the original netscape engineer working
on this is over-burdened. If you feel this is an error, that you or another
known resource will be working on this bug,or if it blocks your work in some way
-- please attach your concern to the bug for reconsideration.

Comment 8

[waqar]

FOrgot to set the milestone.

Comment 9

[Kevin McCluskey (gone)]

bulk reassigning Waqar's bugs to Don.

Comment 10

[dcone (gone)]

I did a cross reference on  NGLayoutConfigInclude.h, and I do believe its not
used anylonger.  I found one reference that was commented out.  I think this
issue was cleared up.

Comment 11

[Simon Fraser [no longer active]]

This is not the case. See
<http://lxr.mozilla.org/mozilla/source/build/mac/build_scripts/
MozillaBuildList.pm#520>

Comment 12

[dcone (gone)]

Simon.. I think you should handle this.. I dont know very much about the Mac 
build system build scripts.

Comment 13

[Peter Van der Beken [:peterv]]

Attachment: Remove NGLayoutConfigInclude.h

Comment 14

[Peter Van der Beken [:peterv]]

Taking. Patch removes NGLayoutConfigInclude.h. Everything still builds,
MOZ_NGLAYOUT was removed a while ago ;-). I also checked for the include and
MOZ_NGLAYOUT by searching my tree and by using http://lxr.mozilla.org/mozilla/.
Looking for sr from Simon (patch includes commercial files).

Comment 15

[Simon Fraser [no longer active]]

Comment on attachment 71114 [details] [diff] [review]
Remove NGLayoutConfigInclude.h

Thank you Thank you Thank you. sr=sfraser

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 71114 [details] [diff] [review]
Remove NGLayoutConfigInclude.h

a=dbaron for trunk checkin

Comment 17

[Peter Van der Beken [:peterv]]

Checked in.