579412 - Focus inputNode on JSTerm when opening the HUD/Console

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Julian Viereck]

Attachment: [backed-out] Patch

When you open up the HUD/Console, the inputNode is not focused.

The inputNode should be focused to increate the workflow.

Comment 1

[Dietrich Ayala (:dietrich)]

Comment on attachment 457897 [details] [diff] [review]
[backed-out] Patch

much nicer, r=me, thanks!

Comment 2

[Julian Viereck]

Comment on attachment 457897 [details] [diff] [review]
[backed-out] Patch

Requesting approval as this patch improves the UX for the WebConsole. Instead of opening the WebConsole and setting the focus to the inputNode to start typing/testing thing the focus is set to the inputNode automatically when the WebConsole is opened. This one step less to do speeds up development/testing for the WebConsole also.

Comment 3

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 457897 [details] [diff] [review]
[backed-out] Patch

http://hg.mozilla.org/mozilla-central/rev/b993e9c8edbe

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Did this cause some failures

Comment 5

[Rob Campbell [:rc] (:robcee)]

had to backout due to test failures.

see, http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1279891381.1279892248.10989.gz

for example.

Comment 6

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 457897 [details] [diff] [review]
[backed-out] Patch

need a fix for test failures

Comment 7

[Patrick Walton (:pcwalton)]

Attachment: New proposed patch.

New patch. The "jsterm" property is only defined immediately after the console is created, which was causing the test failures. Mochitests now pass.

Comment 8

[Patrick Walton (:pcwalton)]

Comment on attachment 459885 [details] [diff] [review]
New proposed patch.

Rescinding review request due to lack of unit tests.

Comment 9

[Patrick Walton (:pcwalton)]

Attachment: New proposed patch, version 2.

New proposed patch, version 2, with a mochitest.

Comment 10

[Patrick Walton (:pcwalton)]

http://hg.mozilla.org/mozilla-central/rev/7ca4b43c3210

Comment 11

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

FWIW, querySelectorAll(x)[0] == querySelector(x), and the latter could be a little more efficient.

Comment 12

[Rob Campbell [:rc] (:robcee)]

I was thinking the same thing as above in Comment 11. Otherwise, this is checked in so it should be a follow-up bug.