57958 - use PR_LOG instead of fprintf(stderr,"")

Status: VERIFIED FIXED

(MailNews Core :: Movemail, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

see my comment in bug #56666

Comment 1

[(not reading, please use [e-mail] instead)]

adam, see news://news.mozilla.org:119/[e-mail]

Comment 2

[Adam D. Moss]

Attachment: fprintf -> nslog's NS_LOG_PRINTF

Comment 3

[Adam D. Moss]

The attached patch uses nslog's logging facility,
which seems to be the new wave (in preference to
PR_LOG).

(Unfortunately the fix for bug 58038 is mixed in there
too; either solely this patch needs to be checked in
once both bugs' patches are approved, or I will re-generate
a patch against the trunk once 58038's patch is in.)

Comment 4

[(not reading, please use [e-mail] instead)]

you'll have to wait until warren re-lands his fix for bug 47207.

Comment 5

[Adam D. Moss]

Hmm, this is sort of blocking up my tree
now, since the patch is so cross-mingled with
other fixes.  Remember, kids: logging APIs come
and go but printf() is forever.  =)

Comment 6

[(not reading, please use [e-mail] instead)]

I don't think the NS_LOG_PRINT stuff is ever going to land.

(warren has left the company).

can you submit a new patch for fprintf -> PR_LOG?

Comment 7

[(not reading, please use [e-mail] instead)]

I take it back, I think the NS_LOG_PRINTF stuff has landed, I see it is used in
nsAtomTable.cpp

feel free to use NS_LOG_PRINTF or PR_LOG.

Comment 8

[Adam D. Moss]

I'll be revisiting this 'RSN'.

Comment 9

[Adam D. Moss]

Properly moving to movemail component.

Comment 10

[Philip K. Warren]

Taking bug.

Comment 11

[Philip K. Warren]

Attachment: Patch v1

This replaces all of the MOVEMAIL_DEBUG code with PR_LOG statements.

Comment 12

[Philip K. Warren]

Fixed.

Checking in nsMovemailService.cpp;
/cvsroot/mozilla/mailnews/local/src/nsMovemailService.cpp,v  <-- 
nsMovemailService.cpp
new revision: 1.41; previous revision: 1.40
done

Comment 13

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified using LXR.

1.41	pkw%us.ibm.com	2004-02-10 13:58	 	Bug 57958 - use PR_LOG instead of
fprintf(stderr, "")
r/sr=[e-mail]