579765 - Not using GTK filechooser anymore

Status: RESOLVED FIXED

(Core Graveyard :: File Handling, defect)

Description

[Michael Monreal [:micmon]]

Attachment: Screenshot

In the 20100718 nightly I noticed that the GTK filechooser is not used anymore for save and open operations. I really hope this is a regression and not by design.

Comment 1

[Dave Garrett]

Appears to be a regression somehow caused by bug 576991.

Comment 2

[Alexey Gladkov]

Somehow the ui.allow_platform_file_picker not used anymore.
I'll try to find out why.

Comment 3

[Alexey Gladkov]

I think I know what the problem.

Comment 5

[Benjamin Smedberg]

http://hg.mozilla.org/mozilla-central/rev/6575d77caf4f I backed out the nsFilePicker.manifest change from bug 576991 which I'm pretty sure was incorrect.

Comment 6

[Alexey Gladkov]

Attachment: nsFilePicker fix

This is a really stupid mistake. nsFilePicker calls the nsFilePicker.js by CID.

Comment 7

[Alexey Gladkov]

(In reply to comment #5)
> http://hg.mozilla.org/mozilla-central/rev/6575d77caf4f I backed out the
> nsFilePicker.manifest change from bug 576991 which I'm pretty sure was
> incorrect.

Yes. I'm sorry. But other changes are correct.

Comment 8

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 458578 [details] [diff] [review]
nsFilePicker fix

r=me, but Benjamin checked this in already.

Comment 10

[[e-mail]]

I thought the XUL filepicker was only built on GTK builds anyway?