58121 - select all and changing style on this document causes blue boxes everywhere

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect, P3)

Description

[sujay]

using 10/26 build of netscape

1) launch netscape
2) jump to URL above
3) open in composer
4) Edit | Select All
5) change to either bold/italic

notice the blue rectangles everywhere around the text.

Comment 1

[Simon Fraser [no longer active]]

This was a side-effect of the form editing changes I landed ages ago.

Comment 2

[rubydoo123]

moving this out to future -- we will try and resolve this when we can

Comment 3

[Joe Francis]

this bug really fries my bacon.  can we moz 0.9 it?  why is it p3?

Comment 4

[Simon Fraser [no longer active]]

Bring back to .9

Comment 5

[Simon Fraser [no longer active]]

Attachment: nsHTMLContainerFrame fix

Comment 6

[Simon Fraser [no longer active]]

The fix is to not have nsHTMLContainerFrame::Paint call nsFrame::Paint, which was 
added so that some kinds of form control get blue boxes when selected in editor 
(but bug 48716 has an alternative fix for that).

Looking for r=/sr=

Comment 7

[Joe Francis]

i can r this if no one else will, but i'd prefer mike or someone more familiar 
with this stuff to look at it.  I really want it to land though!  

Comment 8

[kinmoz]

Thanks for fixing this simon, you can have my r=/sr= depending on what you need 
if you can get either atinassi or rods to sign off on it.

Comment 9

[Marc Attinasi]

I like the change - I don't want all container frames calling nsFrame::Paint, in
fact, I'm not even sure I like what nsFrame::Paint is doing at all, but then
several other frames are relying on it to do this. I'd prefer for nsFrame to
have a different method that takes care of the blue-box painting, and have that
method get called only when appropriate, like when in composer. Maybe mjudge
should check this out, he added that code I think.

Anyway, the change seems fine: [s]r=attinasi

Comment 10

[Simon Fraser [no longer active]]

Fix checked in.

Comment 11

[R.K.Aa.]

did those squares look anything like the ones in right-hand column at
http://www.dn.no ?

Comment 12

[Simon Fraser [no longer active]]

I see no squares in the RH column at that site, and this bug fix only affects 
composer.

Comment 13

[Joe Francis]

wohoo!!!

Comment 14

[sujay]

verified in 4/19 build.