58477 - GetRootContent and GetDocumentElement callers must null-check

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

As vidur pointed out in bug 40121, we need to make sure that all callers of
nsIDocument::GetRootContent and nsIDOMDocument::GetDocumentElement check for
null, since these functions may return null in rare cases.

Comment 1

[Johnny Stenback (:jst)]

Attachment: Proposed fix for some of the possible problems.

Comment 2

[Johnny Stenback (:jst)]

Attachment: New patch without my stupid boogs that scc caught.

Comment 3

[Blake Ross]

Looks good. r=blake

Comment 4

[Johnny Stenback (:jst)]

Thenks for the reviews (blake and scc), now there's only one place remaining
that needs to deal with null root element cases (possibly), that's at
http://lxr.mozilla.org/seamonkey/source/layout/xbl/src/nsXBLWindowHandler.cpp#193
so I'll let hyatt deal with that.

Comment 5

[Peter Trudelle]

->moz0.9

Comment 6

[Peter Trudelle]

->dr

Comment 7

[Dan Rosen]

Attachment: yet another null check

Comment 8

[Dan Rosen]

this fixes this instance (looking for r=, etc...) but there are other places in
the code where these functions aren't null-checked (nsHTMLEditor.cpp and
nsXULElement.cpp to name a couple).

i'll check this in asap and then throw this back at jst, since he seemed to know
something about which calls should and shouldn't need null-checking.

Comment 9

[Dan Rosen]

Attachment: previous patch, post-layout-content-split

Comment 10

[Peter "jag" Annema]

r=jag

Comment 11

[Dan Rosen]

sr=hyatt. i'll check in when the tree opens.

Comment 12

[Dan Rosen]

checked in (cvs rev 1.5). jst, i'm marking this as fixed -- could you verify, if
there are indeed no more cases where this needs to be null-checked? i noticed
some calls in nsHTMLEditor.cpp, nsXULElement.cpp, but it sounded like you knew
something about those cases... thanks!

Comment 13

[Prashant Desale]

QA contact Update

Comment 14

[Prashant Desale]

Updating QA contact to Shivakiran Tummala.

Comment 15

[Sivakiran Tummala]

johnny can u please verify this bug...

Comment 16

[Johnny Stenback (:jst)]

Verified.