585195 - Theme the Web Console filter bar appropriately on Windows

Status: RESOLVED FIXED

(Firefox :: Theme, defect)

Description

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch.

It would be nice if the Web Console filter bar looked like a native platform filter bar on Windows. The attached patch does this. It's based on the filter bars in Thunderbird (cf. comm-central/mail/themes/qute/mail/quickFilterBar.css).

Comment 1

[David Dahl :ddahl]

Can you post a screenshot?

Comment 2

[David Dahl :ddahl]

Comment on attachment 463672 [details] [diff] [review]
Proposed patch.

+ with screenshot

Comment 3

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch (trunk rebase 2010-08-11).

Patch rebased to trunk.

Comment 4

[Patrick Walton (:pcwalton)]

Comment on attachment 463672 [details] [diff] [review]
Proposed patch.

Canceling review on this one because it no longer applies.

Comment 5

[Dietrich Ayala (:dietrich)]

Can you attach a screenshot, per comment #2?

Comment 6

[Patrick Walton (:pcwalton)]

Attachment: Screenshot.

Screenshot attached.

Comment 7

[Dietrich Ayala (:dietrich)]

Comment on attachment 465068 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-11).

thanks, looks great. r=me.

Comment 8

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 465068 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-11).

can we get some approval for this?

Comment 9

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 465068 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-11).

http://hg.mozilla.org/mozilla-central/rev/e751acb410d0

Comment 10

[Patrick Walton (:pcwalton)]

This was backed out in revision da59cce7bfa2.

Comment 11

[Dão Gottwald [:dao]]

Comment on attachment 465068 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-11).

>+    background: -moz-linear-gradient(top, #f2f7fd 0, #e9f2fc 12px, #e3eefb 12px, #e3eefb 100%);

This is going to look entirely inappropriate on XP, isn't it?

Comment 12

[David Dahl :ddahl]

(In reply to comment #11)
> Comment on attachment 465068 [details] [diff] [review]
> Proposed patch (trunk rebase 2010-08-11).
> 
> >+    background: -moz-linear-gradient(top, #f2f7fd 0, #e9f2fc 12px, #e3eefb 12px, #e3eefb 100%);
> 
> This is going to look entirely inappropriate on XP, isn't it?

Sounds like it will. How do we handle the case of a style for XP and a style for vista/7?

Comment 13

[Dão Gottwald [:dao]]

Before we get into the implementation details, could somebody please point me to a native filter bar example? Thunderbird isn't the best role model for a native app.

I don't quite like how this seemingly tries to integrate with the primary toolbars -- it fails halfway, because of the border and because the gradient starts anew. We wouldn't even want it to integrate seamlessly, since the filter bar belongs to content below it rather than the toolbars above it. So just using -moz-appearance: none; background-color: -moz-dialog; for a clean cut might be better.

Comment 14

[David Dahl :ddahl]

(In reply to comment #13)
> Before we get into the implementation details, could somebody please point me
> to a native filter bar example? Thunderbird isn't the best role model for a
> native app.

No idea where to point you:)

> 
> I don't quite like how this seemingly tries to integrate with the primary
> toolbars -- it fails halfway, because of the border and because the gradient
> starts anew. We wouldn't even want it to integrate seamlessly, since the filter
> bar belongs to content below it rather than the toolbars above it. So just
> using -moz-appearance: none; background-color: -moz-dialog; for a clean cut
> might be better.

Sounds like a simpler, better approach.

Comment 15

[Kevin Dangoor]

This should be a blocker, because we want the console to look right on Windows.

Comment 16

[Dão Gottwald [:dao]]

(In reply to comment #15)
> This should be a blocker, because we want the console to look right on Windows.

Bug severity is different from release blocking status.

Comment 17

[Dietrich Ayala (:dietrich)]

not going to hold the release for thematic polish on developer-focused non-primary UI, blocking-.

earlier patch already has approval. if new changes are ready, carry it over.

Comment 18

[Patrick Walton (:pcwalton)]

Attachment: [checked-in] Proposed patch, version 2.

New patch address Dao's comments and uses -moz-dialog.

Comment 19

[Patrick Walton (:pcwalton)]

Attachment: Screenshot, version 2.

New screenshot posted.

Comment 20

[Dietrich Ayala (:dietrich)]

Comment on attachment 473098 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

dao's review here is more appropriate, and enough.

Comment 21

[Patrick Walton (:pcwalton)]

(In reply to comment #20)
> Comment on attachment 473098 [details] [diff] [review]
> Proposed patch, version 2.
> 
> dao's review here is more appropriate, and enough.

Okay, switched r? to him.

Comment 22

[Kevin Dangoor]

Comment on attachment 473098 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

Requesting approval for this simple patch that is an important visual improvement on Windows.

Comment 23

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 473098 [details] [diff] [review]
[checked-in] Proposed patch, version 2.

http://hg.mozilla.org/mozilla-central/rev/0425b1e11d2d