Closed Bug 586125 Opened 14 years ago Closed 11 years ago

"Copy", "Select All", etc. popup menu item in the Web Console displays keyboard shortcuts

Categories

(DevTools :: Console, defect, P3)

Product:
DevTools
Component:
Console
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 23

People

(Reporter: pcwalton, Assigned: sinduja_psg)

References

Details

(Whiteboard: [good-first-bugs][lang=js][mentor=msucan])

Attachments

(1 file, 3 obsolete files)

Removed keyboard shortcuts
1.29 KB, patch
msucan
: review+
Details | Diff | Splinter Review
Attached patch Proposed patch. (obsolete) — — Splinter Review 
The "Copy" popup menu item in the Web Console displays the Cmd+C shortcut key, but nowhere else do we display shortcut keys in popup menus (nor, in general, do the underlying OS's).

The attached patch removes the access key. Requesting approval for Firefox 4 as a platform integration fix.
Attachment #464632 - Flags: feedback?(ddahl)
Attachment #464632 - Flags: feedback?(ddahl) → feedback?(jviereck)
Assignee: nobody → pwalton
Status: NEW → ASSIGNED
Comment on attachment 464632 [details] [diff] [review]
Proposed patch.

Patch is okay + tested by using my eyes on OSX 10.6.

Patrick, are you sure that no OS displays the key shortcut? Maybe ask Neil about it?
Attachment #464632 - Flags: feedback?(jviereck) → feedback+
Attachment #464632 - Flags: review?(dietrich)
I checked on Windows and Mac.
Comment on attachment 464632 [details] [diff] [review]
Proposed patch.

Patch no longer applies, so canceling review. Will upload rebased version.
Attachment #464632 - Flags: review?(dietrich)
Patch rebased to trunk. Review requested.
Attachment #465066 - Flags: review?(dietrich)
Attachment #465066 - Attachment is patch: true
Attachment #465066 - Attachment mime type: application/octet-stream → text/plain
Where exactly is this menu item?
Select some content in the WebConsole/HUD output. Then, perform a right click to see the menu.
Attachment #465066 - Flags: review?(dietrich) → review+
Attachment #465066 - Flags: approval2.0+
I think you're mixing two different things here - an accesskey and a commandkey. It's OK to remove the commandkey, but please leave the accesskey as is. We are using accesskeys in all our context menus, so we should stay consistent here. Windows uses accesskeys in context menus as well, they are hidden for Vista and above, but they are present (press context menu key to display them temporarily). We don't have an ability to hide accesskeys in XUL yet, but that's other bug.
(In reply to comment #7)
> I think you're mixing two different things here - an accesskey and a
> commandkey. It's OK to remove the commandkey, but please leave the accesskey as
> is. We are using accesskeys in all our context menus, so we should stay
> consistent here. Windows uses accesskeys in context menus as well, they are
> hidden for Vista and above, but they are present (press context menu key to
> display them temporarily). We don't have an ability to hide accesskeys in XUL
> yet, but that's other bug.

You're right. Rescinding these patches.
Summary: "Copy" popup menu item in the Web Console displays an access key → "Copy" popup menu item in the Web Console displays a keyboard shortcut
Attachment #465066 - Attachment is obsolete: true
Attachment #464632 - Attachment is obsolete: true
Whiteboard: [strings]
Whiteboard: [strings]
Comment on attachment 465066 [details] [diff] [review]
Proposed patch (trunk rebase 2010-08-11).

(bookkeeping)
Attachment #465066 - Flags: approval2.0+
I don't think this is a bug
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → INVALID
No, this is a bug. No other context menu in Firefox displays command keys.
Status: RESOLVED → REOPENED
Resolution: INVALID → ---
Assignee: pwalton → nobody
Component: Developer Tools → Developer Tools: Console
Whiteboard: [good-first-bugs][lang=js][mentor=msucan]
Filter on TARDIS.
Priority: -- → P3
Summary: "Copy" popup menu item in the Web Console displays a keyboard shortcut → "Copy", "Select All", etc. popup menu item in the Web Console displays keyboard shortcuts
I'd like to take this bug. Please let me know on where to start
Daniel: please get the Firefox source code and build Firefox on your OS. How to do this:

https://developer.mozilla.org/en-US/docs/Simple_Firefox_build

Before you fix the bug, please see:

https://developer.mozilla.org/en-US/docs/Developer_Guide

Make a patch and submit it:

https://developer.mozilla.org/en-US/docs/Developer_Guide/How_to_Submit_a_Patch

For this bug please edit browser/devtools/webconsole/webconsole.xul. Find #output-contextmenu and change menu_copy to cMenu_copy. Do the same for "select all".

Thank you!
Assignee: nobody → desiradaniel2007
Status: REOPENED → ASSIGNED
Version: unspecified → Trunk
Assignee: desiradaniel2007 → nobody
Hi

I would like to work on this bug. Can you assign it to me?

Thanks
Sinduja
Thanks for your interest. Please read the comments in this bug to make sure you understand what needs to be done.

Please let me know if you have any questions.
Assignee: nobody → sinduja_psg
Attached patch Removing Keyboard shortcuts (obsolete) — — Splinter Review 
Fixed as per the comment
Attachment #740019 - Flags: review?(mihai.sucan)
Fixed as per the comment
Attachment #740019 - Attachment is obsolete: true
Attachment #740019 - Flags: review?(mihai.sucan)
Attachment #740021 - Flags: review?(mihai.sucan)
Comment on attachment 740021 [details] [diff] [review]
Removed keyboard shortcuts

Thank you!
Attachment #740021 - Flags: review?(mihai.sucan) → review+
Whiteboard: [good-first-bugs][lang=js][mentor=msucan] → [land-in-fx-team][good-first-bugs][lang=js][mentor=msucan]
https://hg.mozilla.org/integration/fx-team/rev/0efd2a5edfc8
Whiteboard: [land-in-fx-team][good-first-bugs][lang=js][mentor=msucan] → [fixed-in-fx-team][good-first-bugs][lang=js][mentor=msucan]
https://hg.mozilla.org/mozilla-central/rev/0efd2a5edfc8
Status: ASSIGNED → RESOLVED
Closed: 13 years ago → 11 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team][good-first-bugs][lang=js][mentor=msucan] → [good-first-bugs][lang=js][mentor=msucan]
Target Milestone: --- → Firefox 23
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: