586135 - Web Console input field isn't resized when the user presses Return

Status: RESOLVED INVALID

(DevTools :: General, defect)

Description

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch.

When the user presses Return to submit a long line of JavaScript, the Web Console field isn't resized. This problem also occurs on other events that change the value of that field without triggering key presses (undo, for example).

The attached patch fixes this.

Requesting blocking status for Firefox 4 because this is a serious UI issue with the Console.

Comment 1

[David Dahl :ddahl]

Please set the feedback flag with a bugzilla id:)

Comment 2

[Julian Viereck]

Comment on attachment 464657 [details] [diff] [review]
Proposed patch.

>+  /**
>+   * Sets the value of the input field (command line), and resizes the field to
>+   * fit its contents. This method is preferred over settings "inputNode.value"
>+   * directly, because it correctly resizes the field.
>+   *
>+   * @param string newValue
>+   *        The new value to set.
>+   * @returns void
>+   */
>+  setInputValue: function JST_setInputValue(newValue)
>+  {
>+    this.inputNode.value = newValue;
>+    this.resizeInput();
>+  },
>+

Use aNewValue as argument variable. Otherwise f+!

Comment 3

[Patrick Walton (:pcwalton)]

Attachment: Proposed patch (revised per feedback).

Patch revised per feedback.

Comment 4

[Kevin Dangoor]

Comment on attachment 466720 [details] [diff] [review]
Proposed patch (revised per feedback).

Requesting approval to land this in Firefox 4.

Comment 5

[Patrick Walton (:pcwalton)]

The Web Console doesn't actually resize anymore due to a regression, so this bug is no longer applicable.

Comment 6

[David Dahl :ddahl]

(In reply to comment #5)
> The Web Console doesn't actually resize anymore due to a regression, so this
> bug is no longer applicable.

will it be reopened after the regression is fixed?

Comment 7

[Patrick Walton (:pcwalton)]

(In reply to comment #6)
> (In reply to comment #5)
> > The Web Console doesn't actually resize anymore due to a regression, so this
> > bug is no longer applicable.
> 
> will it be reopened after the regression is fixed?

Presumably the patch that fixes the regression will fix this one as well :)

Comment 8

[Dietrich Ayala (:dietrich)]

Canceling blocking per comment #5.

Comment 9

[Dietrich Ayala (:dietrich)]

Blocking request, that is.