Closed Bug 58629 Opened 25 years ago Closed 24 years ago

Quoting this message loses data

Categories

(Core :: DOM: Editor, defect, P3)

Product:
Core
Component:
DOM: Editor
Platform:
x86
Windows NT
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.6

People

(Reporter: phil, Assigned: mozeditor)

Details

(Keywords: dataloss, Whiteboard: EDITORBASE; FIXINHAND; patch in 77902)

Attachments

(2 files)

message demonstrating the problem
2.07 KB, text/plain
Details
mailbox with test messages
2.04 KB, text/plain
Details
Using 2000-10-30-04 RTM branch build on NT 1. Append the attached mail message to your mail folder 2. Run the app and read the message 3. Reply to the message Expected: Message to be quoted in its entirety Actual: Body text containing 'x' characters is deleted. No, this isn't specific to 'x' characters -- I just marked up the original message so I could attach it here.
cc rhp, add keywords
Keywords: dataloss, rtm
I am looking at it...
Status: NEW → ASSIGNED
Look like the problem is in editor and not in msgcompose. The problem is that nsIEditorShell->InsertAsCitedQuotation() eat the list item (<LI>...</LI>) for some reason when this one is at the top level! when I reply to a simple message like: <html><li>hello world</li></html> the data is lost but with the same message without the <li>, it's fine: <html>hello world</html> I will attach a sample mailbox that let you test that..
reassign to editor team.
Assignee: ducarroz → beppe
Status: ASSIGNED → NEW
assigning to joe to take a look at why li is getting deleted and adding akkana for insight as well
Assignee: beppe → jfrancis
Target Milestone: --- → mozilla0.9
<li> not inside a list are technically illegal, I believe. Nevertheless, lots of people use that construct (and I believe 4.x composer generated it), so we need to handle it. Maybe the DTD is being too strict about what it will insert?
yes, that is what is happening. I switched over to the "strict" dtd for editor operations. The normal dtd is still used for loading a document, so I thought we would be ok for existing mal-formed docs. We would just enforce good html when editing. But mail quoting is an exception. It goes through the same code path as paste, rather than document loading. I'm not sure what to do here. I guess we can special case mail quoting to use the "normal" dtd. Or it could go back to using no dtd (ie, we'll let you mailquote anything, even if it in no way resembles anything halfway valid).
Status: NEW → ASSIGNED
How often is the illegal construct created by 4.x? Would 4.x mail do it too?
Whiteboard: [need info]
rtm-, too late for this type of change, no patch available.
Whiteboard: [need info] → [rtm-]
To answer Steve's question, yes, the way I found this bug is trying to reply to a message sent by 4.7
moving misc editor bugs into browser product
Component: Composition → Editor
Product: MailNews → Browser
Target Milestone: mozilla0.9 → ---
will the bug fix for 67007 impact this bug?
alas no. that will let us paste userdefined tags. but real html tags that are in illegal places will still get stripped out on paste. I'll have to alter mailquoting to simply not perform any checks at all.
Target Milestone: --- → mozilla0.9.1
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Keywords: rtm
Whiteboard: [rtm-]
I've tried reproducing this bug and I just can't get it to lose data -- I had terri p. send a new message from 4.x with the li and text and replying did not corrupt the content. Asking Esther to retest on a current build to see if she can reproduce this, here is the body of what she sent: rom - Tue May 22 17:09:14 2001 X-Mozilla-Status: 0001 X-Mozilla-Status2: 00000000 Return-Path: <tpreston@netscape.com> Received: from netscape.com ([206.222.241.111]) by dredd.mcom.com (Netscape Messaging Server 4.15) with ESMTP id GDRH7U00.CCO for <beppe@netscape.com>; Tue, 22 May 2001 16:57:30 -0700 Message-ID: <3B0AFDDA.2C4B6F89@netscape.com> Date: Tue, 22 May 2001 17:01:31 -0700 From: tpreston@netscape.com (Terri Preston) X-Mailer: Mozilla 4.77 [en] (Windows NT 5.0; U) X-Accept-Language: en MIME-Version: 1.0 To: beppe@netscape.com Subject: Why is terri so great? Content-Type: text/html; charset=us-ascii Content-Transfer-Encoding: 7bit <!doctype html public "-//w3c//dtd html 4.0 transitional//en"> <html> <li>she sent this to beppe</li> </html> btw -- when I received this note, which she created in 4.x, the li had a UL wrapped around it, I removed the UL via a plaintext editor (notepad)
my patch in 35295 fixes this
Whiteboard: patch in 35295
Keywords: perf
Whiteboard: patch in 35295 → [perf]patch in 35295
Target Milestone: mozilla0.9.2 → mozilla1.0
096
Target Milestone: mozilla1.0 → mozilla0.9.6
Whiteboard: [perf]patch in 35295 → EDITORBASE; 1 day; [perf]patch in 35295
There is a new patch (which can actually land) in bug 77902 that fixes this. This is similar to the performance work I did in bug 35295, but I didn't remove the newline replacement code in this patch, so it is safe to use for mail.
Keywords: perf
Whiteboard: EDITORBASE; 1 day; [perf]patch in 35295 → EDITORBASE; FIXINHAND; patch in 77902
fix checked in on trunk
Status: ASSIGNED → RESOLVED
Closed: 24 years ago
Resolution: --- → FIXED
Verified on build 2001110903.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: