58747 - Smiley face not shown in "Message Display" prefs in classic theme

Status: VERIFIED FIXED

(SeaMonkey :: Themes, defect, P2)

Description

[Branko Čibej]

There's a buglet in the Classic theme: the prefpanels.css stylesheet is missing
from the skin, so the smiley face isn't shown in the "Message Display" pane. I
just copied the file and binding from the Blue theme. Here's a patch.

diff -rc bin/chrome/classic/skin/classic/communicator/communicator.css
Seamonkey/chrome/classic/skin/classic/communicator/communicator.css
*** bin/chrome/classic/skin/classic/communicator/communicator.css	Wed Aug 23 18:38:06 2000
--- Seamonkey/chrome/classic/skin/classic/communicator/communicator.css	Wed Nov  1 17:12:51 2000
***************
*** 13,18 ****
--- 13,19 ----
  @import url(chrome://communicator/skin/brand.css);
  @import url(chrome://communicator/skin/menubutton.css);
  @import url(chrome://communicator/skin/formatting.css);
+ @import url(chrome://communicator/skin/prefpanels.css);
  @import url(chrome://communicator/skin/toolbar.css);
  /* should we put this here, or make a dialog include it specifically? */
  @import url(chrome://communicator/skin/search-widgets.css);
diff -cP bin/chrome/classic/skin/classic/communicator/prefpanels.css
Seamonkey/chrome/classic/skin/classic/communicator/prefpanels.css
*** bin/chrome/classic/skin/classic/communicator/prefpanels.css Thu Jan  1
01:00:00 1970
--- Seamonkey/chrome/classic/skin/classic/communicator/prefpanels.css   Wed Nov
1 16:29:26 2000
***************
*** 0 ****
--- 1,21 ----
+ /********** Fonts ***************/
+
+ #sizeVar, #sizeMono {
+       width: 4em;
+ }
+
+ #mouseWheelMode {
+       width: 9em;
+ }
+
+ /******* SmartBrowsing **********/
+
+ #disabledDomains {
+       max-height: 13em;
+ }
+
+
+ .smileface
+   {
+     list-style-image : url("chrome://messenger/skin/smile.gif");
+   }

Comment 1

[sairuh (rarely reading bugmail)]

confirming, and over to themes.

Comment 2

[hangas]

Sending to Andrew

Comment 3

[Blake Ross]

*** Bug 55002 has been marked as a duplicate of this bug. ***

Comment 4

[Jessica Blanco]

We're willing to check in the code for this bug. Is anybody interested 
in getting this fixed?

Comment 5

[sairuh (rarely reading bugmail)]

jessica, that'd be great! pls attach a patch to this bug and add the
patch/review keywords to get onto someone's radar for review/checkin... thx!

Comment 6

[Jessica Blanco]

Attachment: Added prefpanels.css to the jar file

Comment 7

[Jessica Blanco]

Attachment: prefpanels.css -same as in blue and modern theme

Comment 8

[Jessica Blanco]

Attachment: Added prefpanels.css to classic\communicator\makefile.win

Comment 9

[Jessica Blanco]

Attachment: Added prefpanels.css to classic\communicator\MANIFEST

Comment 10

[Jessica Blanco]

Attachment: Added prefpanels.css to communicator.css

Comment 11

[andreww]

Ok, I see the patches and I will try them out and get them checked in.

Comment 12

[hangas]

Themes Triage Team nsbeta1+

Comment 13

[andreww]

setting milestone.

Comment 14

[hangas]

Moving to 0.9

Comment 15

[andreww]

Attachment: new patch - for mac and windows classic.

Comment 16

[andreww]

ready for review, I think...

Comment 17

[hangas]

r=hangas

Comment 18

[Joe Hewitt (gone)]

sr=hewitt

Comment 19

[andreww]

Fix checked into the trunk.

Comment 20

[Patty Mac]

Marking verified on all platforms (2001-03-05-08-Mtrunk).