Closed Bug 588540 Opened 14 years ago Closed 14 years ago

NetworkPanel: Display submitted form data formated

Categories

(DevTools :: General, defect)

Product:
DevTools
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: julian.viereck, Assigned: julian.viereck)

References

Details

(Whiteboard: [kd4b5])

Attachments

(1 file, 4 obsolete files)

[backed-out] Patch v2.1.1
12.23 KB, patch
Details | Diff | Splinter Review
Attached patch Patch v1 (obsolete) — — Splinter Review 
Currently, when you inspect a network requests that sent some data to the server as form data, the form data is show only as ugly to read string (they way it's sent to the server). Tree the case of sending form data to the server special and format the data in key: value pairs.
Attachment #467138 - Flags: feedback?(ddahl)
Comment on attachment 467138 [details] [diff] [review]
Patch v1

Is there a function called _setI10N in the network panel patch? shouldn't it be setL10N?

Otherwise looks good.
Attachment #467138 - Flags: feedback?(ddahl) → feedback+
Attached patch Patch v1.1 (obsolete) — — Splinter Review 
Rebased patch.
Attachment #467138 - Attachment is obsolete: true
Attachment #467517 - Flags: review?(dietrich)
Blocks: 587574
Attachment #467517 - Flags: review?(dietrich) → review?(sdwilsh)
Comment on attachment 467517 [details] [diff] [review]
Patch v1.1

>+    let fromDataRegExp = /Content-Type\:\s+application\/x-www-form-urlencoded/;
I think you want to cache this globally (compiling regular expressions isn't exactly cheap).

Also, per RFC 822 (http://tools.ietf.org/html/rfc822#section-3.1.2), a space after the colon is not necessary, so the regular expression should be: /Content-Type\:\s*application\/x-www-form-urlencoded/
A test for the no whitespace case should also be added.

r=sdwilsh with those changes
Attachment #467517 - Flags: review?(sdwilsh) → review+
Whiteboard: [kd4b5]
Attached patch Patch v2 (obsolete) — — Splinter Review 
Improved based on Shawn's latest feedback. Also converted from HTML to XHTML + DTD.
Attachment #467517 - Attachment is obsolete: true
Attachment #469443 - Flags: review?(sdwilsh)
Attached patch Patch v2.1 (obsolete) — — Splinter Review 
Rebased version.
Attachment #469443 - Attachment is obsolete: true
Attachment #469885 - Flags: review?(sdwilsh)
Attachment #469443 - Flags: review?(sdwilsh)
Comment on attachment 469885 [details] [diff] [review]
Patch v2.1

r=sdwilsh
Attachment #469885 - Flags: review?(sdwilsh) → review+
Attachment #469885 - Flags: approval2.0+
Rebased patch.
Attachment #469885 - Attachment is obsolete: true
Keywords: checkin-needed
This bug blocks 587574, which is a blocker
Comment on attachment 470110 [details] [diff] [review]
[backed-out] Patch v2.1.1

http://hg.mozilla.org/mozilla-central/rev/95ed0bd8f88b
Attachment #470110 - Attachment description: Patch v2.1.1 → [checked-in] Patch v2.1.1
Comment on attachment 470110 [details] [diff] [review]
[backed-out] Patch v2.1.1

http://hg.mozilla.org/mozilla-central/rev/289e6da90526

leaks.
Attachment #470110 - Attachment description: [checked-in] Patch v2.1.1 → [backed-out] Patch v2.1.1
http://hg.mozilla.org/mozilla-central/rev/ce7602d990f9

after try server success, one more push
Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: