58970 - Range cloneContents not implemented

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P1)

Description

[Dylan Schiemann]

BuildID:    20001031

cloneContents DOM 2 Range method not yet implemented

Reproducible: Always
Steps to Reproduce:
1. attempt to cloneContents from a Range returns not implemented error

Actual Results:  NS_ERROR_NOT_IMPLEMENTED

testcase to follow

Comment 1

[Dylan Schiemann]

Attachment: testcase

Comment 2

[Keyser Sose]

Reporter is this still a problem in the latest nightlies? I am not seeing it on
Windows 98 Mozilla Build 2000120604

Comment 3

[Dylan Schiemann]

It is still in the 20001211 nightly... Anthony is working on DOM Range bugs.
You will see the error message in tools -> JavaScript console.

Comment 4

[Keyser Sose]

Marking NEW as per reporters comments.

Comment 5

[anthonyd]

setting milestone and priority.
anthonyd

Comment 6

[Joe Francis]

finishing up range can be pushed off

Comment 7

[Jeff Yates]

I am attaching a JavaScript "Patch" that can be used as a work around for the 
range object.  This patch adds support for the following:
    Range.innerHTML - read only
    Range.extractContents - as per W3C specs
    Range.cloneContents - as per W3C specs
    Range.insertNode - as per W3C specs
    Range.surroundContents - as per W3C specs
    Range.deleteContents - as per W3C specs - fixes buggy support from Mozilla
    Range.jmyCompareNode - extends Mozilla's compareNode to include
                           the following 2 constants
    Range.NODE_BEFORE_AND_INSIDE = -1;
    Range.NODE_INSIDE_AND_AFTER = -2;

I would like a C++ programmer to implement these in C if possible.

Jeff Yates

Comment 8

[Jeff Yates]

Attachment: Patch for Range functionality

Comment 9

[Jeff Yates]

Attachment: Updated patch with test cases and code commenting (had an error in surroundContent method)

Comment 10

[anthonyd]

Jeff Yates,
It looks like you didnt set the mime type correctly when attaching the patch.  
The patch is just gibberish.  Can yuo please reattach the patch and specify text 
as the mime type? Thanks.
anthonyd

Comment 11

[anthonyd]

setting milestone to 0.9

Comment 12

[Asa Dotzler [:asa]]

Am I missing something here?  Is this a security bug? Why is it marked Netscape
Confidential?

Comment 13

[anthonyd]

that was an accident
anthonyd

Comment 14

[rubydoo123]

moving to mozilla1.0

Comment 15

[kinmoz]

So isn't this bug a dup of 58969?

Comment 16

[anthonyd]

checked in, see 58969

Comment 17

[Jeff Yates]

Reopening bug.

The following code crashes Mozilla 0.9.2 (07-18-2001 build) on Win2k:

var range = document.createRange();
//the next line initializes the range so it can be tested
range.selectNodeContents(document.lastChild);  
var extractFrag = range.createContextualFragment(
              "<b>this is a fragment</b> use to " + 
              "test <b>the cloneContents method</b>");
range.setStart( extractFrag.firstChild.firstChild, 5 );
range.setEnd( extractFrag.lastChild.lastChild, 15 );
var cloneFrag = extractFrag;
if( range.cloneContents )	
	try{ 
		alert("before cloneContents");
		//crashes on the next statement
		cloneFrag = range.cloneContents();    
		alert("after cloneContents");
	} catch(e){}


Jeff Yates
http://www.pbwizard.com

Comment 18

[Johnny Stenback (:jst)]

Did the fix for bug 91614 fix this crash too?

Comment 19

[Blake Ross]

Milestone reality check.

Comment 20

[anthonyd]

i think i will go ahead and check in the bug fix to keep this from crashing, but 
it wont fix the broken functionality.

Comment 21

[anthonyd]

clonecontents no longer crashes with a null doc fragment, but it still needs to 
be re-written to work properly in such a case.  this is scheduled for 1.0.
anthonyd

Comment 22

[Martin van Dijken]

This bug needs to be reopened. I can definitely crash Moz 0.9.7 on Win98 in this
manner. I don't know what fixes have been made earlier, but they're not working
any more. 

Comment 23

[rubydoo123]

based on the last few comments in this bug, I am reopening and reassigning to kin

Comment 24

[rubydoo123]

handing over to new owner

Comment 25

[kinmoz]

This was fixed/re-implemented for mozilla1.0 with the patch in bug 120366 back
in March 2002.

Comment 26

[rubydoo123]

cool, I just wnated to make sure of that, marking verified