591412 - Android make android package step failing due to error in AndroidManifest.xml

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Taylor [:bear]]

make -C embedding/android fails with:

/tools/android-sdk/platforms/android-8/tools/aapt package -f -M AndroidManifest.xml -I /tools/android-sdk/platforms/android-8/android.jar  -S res -F gecko.ap_
AndroidManifest.xml:6: error: Error parsing XML: not well-formed (invalid token)
make[1]: *** [gecko.ap_] Error 1
make[1]: Leaving directory `/builds/slave/mozilla-central-mobile-browser-android-r7-build/build/mozilla-central/objdir/embedding/android'
make: *** [default] Error 2
make: Leaving directory `/builds/slave/mozilla-central-mobile-browser-android-r7-build/build/mozilla-central/objdir/embedding/android'

the reason is line 6 of the generated manifest:

      android:versionName=""2.0b1pre""

Comment 1

[Brad Lassey [:blassey] (use needinfo?)]

this is a regression from bug 581008, backing that out locally fixes it for me

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch

Comment 3

[Michael Wu [:mwu]]

Comment on attachment 469945 [details] [diff] [review]
patch

Looks good

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Attachment: patch, ready to land

Comment 5

[Doug Turner (:dougt)]

http://hg.mozilla.org/mozilla-central/rev/e051ccf2361a

Comment 6

[Dão Gottwald [:dao]]

I backed this out in favor of the fix in bug 591783.

http://hg.mozilla.org/mozilla-central/rev/0f7c277c48d6
http://hg.mozilla.org/mozilla-central/rev/02c50330c493