59438 - mpp_pprime() says 15 is prime!

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P3)

Description

[Nelson Bolyard (seldom reads bugmail)]

When given any number that is equal to 3 mod 4, mpp_pprime says
that number is prime.  

The bug is simply that "res" is not set to MP_NO prior to the 
for (jx = 1; jx < b; jx++)
loop, and if that loop executes zero times (because b is 1),
the result is MP_OK, not MP_NO.

Also, HoAC suggests using sequential values of a, rather than
random values of a.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

mpp_pprime is the Miller Rabin pseudo-primality test.  
I will check in a fix shortly.
I'm also going to do some other cleanup to the code.

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

I believe this bug is fixed in revision 1.13 of mpprime.c.
It passes the new test case I added to mpi-test

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Changed target milestone to show this bug was fixed in NSS 3.1.1