59511 - Can't change rows attribute on trees dynamically

Status: RESOLVED FIXED

(Core :: XUL, defect, P3)

Description

[Stephen P. Morse]

Attached is an example of a tree that contains four elements and initially has 
its rows attribute set to 2.  So it opens with two rows being displayed.  If you 
give it focus (by clicking on it), javascript gets executed which puts up an 
alert showing the initial value of rows (it is indeed 2) and then changes the 
rows attribute to 4.  But the display does not change. 

If you then click on the textfield in the example and then click back on the 
tree, the javascript routine gets called again.  The alert display indeed shows 
that rows is 4 at this time, but the tree is still displaying only two rows. 

If I do a display:none before changing the attribute and then a display:inline 
after changing it, the number of rows appearing on the screen is updated.  It 
would seem that this is a work-around for the bug.

Comment 1

[Stephen P. Morse]

Attachment: xul file to demonstrate the problem.

Comment 2

[Paul Chen]

nav triage team:

Why is this XP Apps? Reassinging to XP Toolkit/Widgets: Trees

Comment 3

[Peter Trudelle]

->moz1.0

Comment 4

[David Hyatt]

Here's an easy one.

Comment 5

[arik devens]

the test case that was posted doesn't seem to work anymore, crashes mozilla in 
fact.

i have a patch for the bug (on my work box, will attach on monday) but i need a 
new test case to make sure it works.

if someone could attach a new test case that works that would be awesome.

Comment 6

[Stephen P. Morse]

It doesn't crash for me, but it doesn't display any values in the tree either.  
That's because of the xul syntax change that occured after this bug was 
reported.  Simply change all occurences of "value" to "label" and the attachment 
will display the problem.  I just tried that change and it still exhibits the 
original problem as reported.

Comment 7

[arik devens]

to get this to run i had to remove the entire treechildren peice (even after
changing it to label)

when i click on the tree i get a js error about Expand not being defined.

Comment 8

[Stephen P. Morse]

I don't get the js error about expand not being defined.

But I'm also not observing the original problem described in this report.  I was 
wrong in my comment above that said that I could still reproduce the original 
comment.  So this probably got fixed somewhere along the line.

So feel free to close this out as WORFSFORME if you desire.

Comment 9

[Stephen P. Morse]

Oops, I meant to say:

   ... could still reproduce the original problem

instead of

   ... could still reproduce the original comment

Comment 10

[Dan Rosen]

arik: check with hyatt, or on n.p.m.xpfe for the full story on the xul syntax
changes.

Comment 11

[arik devens]

Attachment: this is the patch that i have made, still can't test it on this machine though

Comment 12

[arik devens]

Attachment: updated patch

Comment 13

[arik devens]

ok, so i've figured out why the test case wasn't working (small problem in my
setup) and i've tested the new patch i included and it works, but you also have
to patch xul.css with the third patch because css was clobbering the rows= bit.

anyway this should fix the problem

Comment 14

[arik devens]

Attachment: patch for xul.css so that we don't clobber the rows= method

Comment 15

[Brendan Eich [:brendan]]

+tree[rows] {
+height: auto;
+}
+

Indentation by one space for the height: auto; line would conform to prevailing
style, I think.  Total nit, all else looks good to me.

/be

Comment 16

[arik devens]

Attachment: updated xul.css patch with brendan's suggestion

Comment 17

[David Hyatt]

sr=hyatt

Comment 18

[arik devens]

fixed.