Closed Bug 595200 Opened 14 years ago Closed 12 years ago

Cyclic references in HUDService httpActivity

Categories

(DevTools :: Console, defect)

Product:
DevTools
Component:
Console
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 15

People

(Reporter: msucan, Assigned: msucan)

References

Details

(Whiteboard: [console-1][fixed by bug 673148]) 

In HUDService.startHTTPObservation() the httpObserver builds an httpActivity object and a loggedNode object coming from the HUDService.messageFactory() method.

The messageFactory() takes as input the httpActivity object and returns a messageObject that holds the activityObject property as a reference back to the httpActivity object. Then we have the httpObserver which sets httpActivity.messageObject = loggedNode.

A cyclic reference only spells trouble ahead. We should fix this.
Blocks: 529086
Whiteboard: [console-1]
Not sure if this has actually caused any problems, investigation needed.
This is likely to be fixed by the patch of bug 673148
Depends on: async-webconsole
Assignee: nobody → mihai.sucan
Status: NEW → RESOLVED
Closed: 12 years ago
Component: Developer Tools → Developer Tools: Console
QA Contact: developer.tools → developer.tools.console
Resolution: --- → FIXED
Whiteboard: [console-1] → [console-1][fixed by bug 673148]
Target Milestone: --- → Firefox 15
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.