59814 - Can't open history item by pressing enter

Status: VERIFIED FIXED

(Core Graveyard :: History: Global, defect, P3)

Description

[Blake Ross]

Build ID: new trunk

Steps to Reproduce:

(1) Open the Manage Bookmarks or History window
(2) Select an item
(3) Press enter

Same action as double clicking should occur, but instead nothing happens.

Comment 1

[sairuh (rarely reading bugmail)]

blake/jrgm, is this a recent regression? could it be a more general problem with
trees? i've a hunch that it might be so, since i encounter this problem trying
to open another window when hitting Enter for a mail folder. if that's the case,
perhaps this should go to the trees component...?

[am looking at a linux mozilla trunk build from 2000.11.08.08, so presently
don't have a branch build handy. marking All, since this occurs also on linux
--and am guessing also on Mac. claudius/jrgm, if you get to it before me, could
you verify? thx!]

Comment 2

[John Morrison]

The tree widget provides the base keyboard functionality to open and close 
folders, and a framework for adding more elaborate application code.

Implementations such as mailnews threadPane or bookmarks have to supply 
the appropriate logic for actions specific to their needs (i.e., the tree
widget shouldn't/cannot know how to reply to an email, or open a bookmark 
in a new window). 

This particular action (pressing enter opens item) did not work (was not 
implemented) in the branch builds either. (But I think Blake was just filing 
the bug on himself to do this work -- go Blake :-).

Comment 3

[Blake Ross]

Yeah, I'll do it.  It's not a general tree widget problem, we're just being bad 
and firing onclick.

Comment 4

[Cyril Bortolato]

Dupe of 39385

Comment 5

[Blake Ross]

*** Bug 39385 has been marked as a duplicate of this bug. ***

Comment 6

[Viswanath Ramachandran]

nav triage team: p3 for nsbeta1. 

Comment 7

[Blake Ross]

Works for me in bookmarks. -> alec for history

Comment 8

[Alec Flett]

this has got to be really easy..just a key that calls OpenURL() or
something...someone must want to just do this so I can review it, right? :)

Comment 9

[Blake Ross]

okay, I'll do it.

Comment 10

[Blake Ross]

fix landed.

Comment 11

[sairuh (rarely reading bugmail)]

mass-verifying claudius' Fixed bugs which haven't changed since 2001.12.31.

if you think this particular bug is not fixed, please make sure of the following
before reopening:

a. retest with a *recent* trunk build.
b. query bugzilla to see if there's an existing, open bug (new, reopened,
assigned) that covers your issue.
c. if this does need to be reopened, make sure there are specific steps to
reproduce (unless already provided and up-to-date).

thanks!

[set your search string in mail to "AmbassadorKoshNaranek" to filter out these
messages.]