600095 - Followup test fixes after lazy console lands

Status: RESOLVED FIXED

(DevTools :: General, defect, P3)

Description

[David Dahl :ddahl]

There are a few tests that need to be fixed or removed or re-worked after the lazy console lands:

toolkit/components/console/hudservice/tests/browser/browser_webconsole_consoleonpage.js-60-      // is(consoleIFrame, undefined, "Console object was removed fro
m iFrame");
toolkit/components/console/hudservice/tests/browser/browser_webconsole_consoleonpage.js:61:      // TODO: file a followup bug to fix this test

toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_593003_iframe_wrong_hud.js-157-function test() {
toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_593003_iframe_wrong_hud.js-158-  return;
toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_593003_iframe_wrong_hud.js:159:  // TODO: this test is borked by the new lazy console
.

toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_586142_insert_newlines.js-27-function test()
toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_586142_insert_newlines.js-28-{
toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_586142_insert_newlines.js-29-  return;
toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_586142_insert_newlines.js:30:  // TODO: figure out why this test fails. file a follow
up bug

toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js.rej-26-+  // return here as the below bits fail. not sure why. moving on.
toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js.rej:27:+  // TODO: file a bug about this failing test.
toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js.rej-28-+

toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js:303:      // TODO fix this tes, file followup bug
toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js-304-      // let logLogged = (outputChildren[2].textContent.indexOf("logging")
 != -1);
toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js-305-      // ok(logLogged, "log() is logged");
toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js-306-

toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js-225-  return;
toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js-226-  // return here as the below bits fail. not sure why. moving on.
toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js:227:  // TODO: file a bug about this failing test.
toolkit/components/console/hudservice/tests/browser/browser_HUDServiceTestsAll.js-228-

Comment 1

[David Dahl :ddahl]

(In reply to comment #0)
> There are a few tests that need to be fixed or removed or re-worked after the
> lazy console lands:
> 
> toolkit/components/console/hudservice/tests/browser/browser_webconsole_consoleonpage.js-60-
>      // is(consoleIFrame, undefined, "Console object was removed fro
> m iFrame");
> toolkit/components/console/hudservice/tests/browser/browser_webconsole_consoleonpage.js:61:
>      // TODO: file a followup bug to fix this test

This test is now unneeded as there is "always" a console available. You can remove it, but it will re-attach itself automatically

Comment 2

[David Dahl :ddahl]

fixed this one:
toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_593003_iframe_wrong_hud.js

Very strange, as it was a test infrastructure / timing issue that only reared its head with the new lazy console

Comment 3

[David Dahl :ddahl]

toolkit/components/console/hudservice/tests/browser/browser_webconsole_bug_586142_insert_newlines.js

was an easy fix. Looks like I lopped out the bits that added newlines to API logged messages. added it back, tests pass.

Comment 4

[David Dahl :ddahl]

In HUDServiceTestsAll.js, the input focus test fails because mochitest changes the focus from what I can gather. I tried to use the focusManager to get the currently focused element and it was null. Have to find a better way to test that.

Comment 5

[David Dahl :ddahl]

removed  testInputFocus() from browser_HUDServiceTestsAll.js as that test is duplicated in browser_webconsole_bug_588342_document_focus.js

Comment 6

[Kevin Dangoor]

mass change: filter on PRIORITYSETTING

Comment 7

[David Dahl :ddahl]

Fixed by bug 587734 landing