60071 - Hide sidebar tab using sidebar context menu

Status: VERIFIED FIXED

(SeaMonkey :: Sidebar, enhancement, P1)

Description

[Alec Flett]

from the CNET review of Netscape 6, they wanted a way to hide a sidebar by
right-clicking on it. I think what we need is a few entries in the sidebar
context menus:

- Hide this panel

and possibly
- Next panel
- Previous panel

(but this bug will be for the "hide" part - next/previous is just an added bonus)

Comment 1

[Blake Ross]

I was just about to file this :-)  God, they mentioned that like twice.  We 
probably would have gotten an 8 if we had it.

reassigning to me.  I was going to do this anyways, but first we have the 
arduous task of making oncommand work in modern-based themes.

Comment 2

[Matthew T (active 1999-2002)]

Next and Previous would make no sense, since it's far faster just to click on the 
panel's tab than to navigate through a context menu.

De-ambiguifying summary.

Comment 3

[Blake Ross]

Right.  So is a context menu even needed?  I suppose it could have a "reload" 
item also.  C|net actually asked that right clicking on a panel just removes it 
from the sidebar without a menu at all, but I'm not sure how intuitive that is.

Comment 4

[Matthew T (active 1999-2002)]

No. Right-click by itself shouldn't ever do anything except open context menus, 
IMO. I was thinking more of a little context menu like this:

  _Hide What's Related
--------------------------
  C_ustomize Sidebar ...

Reload is not necessary -- you should be able to give focus to the panel and then 
just click the Reload button in the toolbar, or press Ctrl+R, or whatever.

Comment 5

[Jesse Ruderman]

>you should be able to give focus to the panel and then just click the Reload 
>button in the toolbar, or press Ctrl+R

I filed bug 61302 for Ctrl+R.

Comment 6

[shrirang khanzode]

spam : changing qa to sujay (New Sidebar QA)

Comment 7

[Jesse Ruderman]

Just to clarify, this is the context menu for the tab and not for the panel 
content, right?

Should the menu include a "default" option matching left-click, perhaps 
callled "show [panel name]"?  (Show sounds like the opposite of hide, though, 
and these commands wouldn't be opposite because show would just focus the 
panel, so maybe "show" isn't the best label for this command.)

Comment 8

[Viswanath Ramachandran]

this is a nsbeta1+ P2 bug. Blake - do you think we'll get this for mozilla0.9.1? 
 

Comment 9

[Blake Ross]

Attachment: patch

Comment 10

[Blake Ross]

Attachment: patch - oh, this includes Jesse's suggestion if we want it

Comment 11

[Blake Ross]

Attachment: Yet Another Patch -- sorry, couldn't/can't test yet due to Windows bustage

Comment 12

[Blake Ross]

Cc'ing potential reviewers.

Comment 13

[Ben Goodger (use ben at mozilla dot org for email)]

OK, blake sez he'll be tidying up the popupset/commands stuff at some point in 
the future, so this code looks OK for the interim. r=[e-mail]

Comment 14

[Blake Ross]

Checked in.  File a new bug to discuss the merits of Switch Panel if necessary.

Comment 15

[sujay]

verified in 5/10 build.