60156 - filepicker does not appear [non-installer?]

Status: VERIFIED FIXED

(SeaMonkey :: UI Design, defect, P3)

Description

[Patrick]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux 2.2.13 i686; en-US; m18) Gecko/20001114
BuildID:    2000111421


Reproducible: Always
Steps to Reproduce:

a. select "save links as..." from the context menu when over a link
-or-
b. select "save image as..." from the context menu when over an image
-or-
c. select "open file..." from the file menu

Actual Results:  nothing happens, nothing on the console indicates an error

Expected Results:  the filepicker appears

Dunno if this is related: instead of Document:Done (nn secs) I get
"An unknown error has occured (804b0005)" on the status line. (The actual error
number varies, though ;e.g. 804b0008). After mousing over a link, this is
replaced with the "Document: Done" message

Comment 1

[Matthias Versen [:Matti]]

WFM on win2k build 2000111404 trunk

Comment 2

[Boris Zbarsky [:bzbarsky]]

I see this on linux trunk 2000111408 and 2000111421 as well.  "Save As" (for the
whole page) also does not work.

Not sure where to assign this too, but ccing blake, since last night on irc he
said that he probably broke it....

Comment 3

[Asa Dotzler [:asa]]

bryner or pavlov?

Comment 4

[sairuh (rarely reading bugmail)]

weird, this WFM --using 2000.11.15.08 opt comm trunk bits. have you tried
today's spins?

i get the filepicker when following your steps --then cancel it. i didn't get
the same console output as you, but after i cancelled the dialog, i got the
following [might be expected since i didn't actually save anything]:

SelectFileAndTransferLocationSpec failed, rv=[Exception... "Component returned
failure code: 0x80004004 (NS_ERROR_ABORT)
[nsIStreamTransfer.SelectFileAndTransferLocationSpec]"  nsresult: "0x80004004
(NS_ERROR_ABORT)"  location: "JS frame ::
chrome://navigator/content/nsContextMenu.js :: anonymous :: line 795"  data: no

marking WFM. pls reopen if it happens with a recent build...perhaps
'mysteriously' fixed last night. :)

Comment 5

[Boris Zbarsky [:bzbarsky]]

Bug is still there in linux 2000-11-15-08 trunk build from the ftp site.

sairuh, what you are seeing is what should normally happen, but it's not
happening...

Comment 6

[sairuh (rarely reading bugmail)]

lessee if we can narrow this down... what theme are you using? [i'm using
modern. --just tried it w/classic and it also works fine.]

does this occur with a particular page? d'you remember what you were doing
before you tried bringing up the filepicker [eg, reading mail, using editor,
etc.]

i'll grab a mozilla trunk build and see if i can repro...

Comment 7

[Boris Zbarsky [:bzbarsky]]

This bug happens with all the themes I have (modern, classic, blue, modern
mozillium).  I tried wiping out .mozilla and package/ and reinstalling and I see
the bug with classi, modern, blue.

Happens on every single page I have tried.

Happens no matter what I am doing beforehand.  I can see it right after I start
up, I can see it after sending some mail, after browsing bugzilla and confirming
some bugs, with and without the java and flash applets.

Does _not_ happen with an optimized debug build from sources dated 11/14/2000
11:50 PST (I pulled by date for that time).

Could this be a build config problem on the automated build machines?

Comment 8

[Christopher Blizzard (:blizzard)]

On builds that I have done on my local machines I see this bug as well so it's
probably not build machine related.

Comment 9

[Christopher Blizzard (:blizzard)]

*** Bug 60144 has been marked as a duplicate of this bug. ***

Comment 10

[don]

Pavlov? ...

Comment 11

[sairuh (rarely reading bugmail)]

mid-air collision... methinks this might be a config issue, since i *was* able
to repro this using the non-installer tarball (finally :). couldn't repro using
the .sea installer blob...

Comment 12

[R.K.Aa.]

*** Bug 60247 has been marked as a duplicate of this bug. ***

Comment 13

[Asa Dotzler [:asa]]

I was able to reproduce the problem using the stub installer today.

Comment 14

[R.K.Aa.]

*** Bug 60253 has been marked as a duplicate of this bug. ***

Comment 15

[sairuh (rarely reading bugmail)]

*** Bug 60258 has been marked as a duplicate of this bug. ***

Comment 16

[sairuh (rarely reading bugmail)]

also, as seen in bug 60258, if a user clicks a link that brings up the helper
app-download dialog, then clicks Save to Disk, s/he won't be able to save the
file at all. eg,

1. go to http://www.mozilla.org/ and scroll to Nightly Builds section
2. click on any of the links
3. when the helper app-download dialog appears, select Save to Disk, then OK

result: nuthin' happens. no filepicker appears, no file is saved.

Comment 17

[Kevin Brown]

Earliest recent version on ftp.mozilla.org that seems to exhibit this bug is
2000-11-13-21-Mtrunk/mozilla-i686-pc-linux-gnu.tar.gz.  I'm posting this with
2000-11-13-08-Mtrunk/mozilla-i686-pc-linux-gnu.tar.gz, which works.

Comment 18

[Brian Ryner (not reading)]

I'm also unable to reproduce this on my tip build.  I'll try the nightly builds
referenced and see if I can get it.

cc'ing alecf, because his stringbundle checkin is the least unlikely suspect
during this time period (among a whole bunch of unlikely suspects)

Comment 19

[Brian Ryner (not reading)]

I have a fix for this, I think.

Comment 20

[Brian Ryner (not reading)]

Attachment: patch

Comment 21

[Brian Ryner (not reading)]

Ok, it looks like the filepicker component wasn't even getting registered.  This
should fix it.

Comment 22

[Brian Ryner (not reading)]

Can someone on the CC list please review?

Comment 23

[Peter "jag" Annema]

Two nits discussed in irc which bryner fixed.

r=jag

Comment 24

[Alec Flett]

just for clarification, what my fix did was to avoid caching the stringbundle 
when you create one with a bad URL.

Are you giving it a bad .properties file?

Comment 25

[Ben Goodger (use ben at mozilla dot org for email)]

a=[e-mail]

Discussed this with bryner on IRC and this prevents:
a) calling methods on a component which may not yet have been registered (string 
bundle service may have been registered after file picker)
b) assigning the result of a function into a constant before the function has 
been defined. 

Comment 26

[Brian Ryner (not reading)]

Checked in.

Comment 27

[Matthias Versen [:Matti]]

*** Bug 60339 has been marked as a duplicate of this bug. ***

Comment 28

[Stephan Jaensch]

Verified.