60325 - [review]<hr> line-height problem caused by large font size

Status: VERIFIED FIXED

(Core :: CSS Parsing and Computation, defect, P3)

Description

[hsd_43]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; m18) Gecko/20001114
BuildID:    2000111404

<hr> tag in a table cell is displayed incorrectly
..... there are breakin spaces but above and below the <hr>

Reproducible: Always
Steps to Reproduce:
just go to the page

Comment 1

[James Lariviere]

--> style system... maybe layout issue.
--> marking NEW.
-->Revising summary. Old Summary:"<hr> tag in a table cell is displayed incorrectly"
-->simple testcase

This whitespace around the horizontal rule is caused by the line-height
adjustment of a 400px font-size declaration in <hr>.

Why would someone set a font-size to a <HR>? 

Comment 2

[James Lariviere]

Attachment: testcase-<hr> with a huge 400px font

Comment 3

[Hixie (not reading bugmail)]

Netscape's standard compliance QA team reorganised itself once again, so taking 
remaining non-tables style bugs. Sorry about the spam. I tried to get this done 
directly at the database level, but apparently that is "not easy because of the 
shadow db", "plus it screws up the audit trail", so no can do...

Comment 4

[Pierre Saslawsky]

It happens because quirk.css defines:
    hr:before { white-space: pre; content: "\A"; }
    hr:after  { white-space: pre; content: "\A"; }

The linefeed characters cause a 400px space on both sides of the HR.  A fix could 
be to add |font-size:-moz-initial !important;| to the HR declaration.  I am 
really not a fan of !important declarations in UA stylesheets but in that case 
it's fine because HRs could not be styled in previous browsers anyhow.

Here is a patch...

Index: mozilla/layout/html/document/src/quirk.css
===================================================================
RCS file: /m/pub/mozilla/layout/html/document/src/quirk.css,v
retrieving revision 1.32
diff -u -2 -r1.32 quirk.css
--- quirk.css	2001/11/05 15:32:25	1.32
+++ quirk.css	2001/11/19 02:17:37
@@ -279,4 +279,5 @@
   -moz-box-sizing: border-box;
   margin: 0 0.1% 0 0.1%; /* Mmm! Hack-on-a-hack for bug 81776 */
+  font-size: -moz-initial !important;
 }

Comment 5

[Pierre Saslawsky]

Marc/Daniel: please r/sr

Comment 6

[Pierre Saslawsky]

Marc/Daniel: I'll copy the above patch into an attachment for your reviewing 
pleasure.

Comment 7

[Pierre Saslawsky]

Attachment: tiny patch

Comment 8

[Daniel Glazman (:glazou) (not active in Mozilla any more)]

Comment on attachment 62348 [details] [diff] [review]
tiny patch

r=glazman

Comment 9

[Marc Attinasi]

Comment on attachment 62348 [details] [diff] [review]
tiny patch

sr=attinasi

Comment 10

[Pierre Saslawsky]

fixed

Comment 11

[Madhur Bhatia]

v