603251 - Fix test: browser_webconsole_basic_net_logging.js

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[David Dahl :ddahl]

Fails on linux debug builds only *on tinderbox*. Still cannot get it to fail locally.

Disabled 2 checks.

Comment 1

[Mihai Sucan [:msucan]]

Attachment: [checked-in] proposed fix

While working on some other patch I bumped into this mochitest file and I saw the TODO. The fix looked quite easy for me to do, and here's the result.

The problem was that the test file used the DOMContentLoaded event which fires before images and scripts from the page are loaded. Besides that, it also had some errors in the way it tried to access the output content to check the presence of the logged requests.

I should note that by enabling the two tests, it did fail for me badly in both debug and opt builds, on Linux.

With this patch, the test runs fine in debug and opt builds.

Comment 2

[David Dahl :ddahl]

Comment on attachment 483712 [details] [diff] [review]
[checked-in] proposed fix

I trust you also tested this after the xray wrapper landed. Looks like my brain had turned to mush when working on this, using the wrong eventHandler call.

Comment 3

[Mihai Sucan [:msucan]]

(In reply to comment #2)
> Comment on attachment 483712 [details] [diff] [review]
> proposed fix
> 
> I trust you also tested this after the xray wrapper landed. Looks like my brain
> had turned to mush when working on this, using the wrong eventHandler call.

Thanks for the feedback+!

I retested this patch today. Still runs fine, no problems with compartments landing.

Comment 4

[Rob Campbell [:rc] (:robcee)]

Comment on attachment 483712 [details] [diff] [review]
[checked-in] proposed fix

http://hg.mozilla.org/mozilla-central/rev/b3e685377d7b