6071 - Node::nodeValue for comment shouldn't have comment delimeters

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Node::nodeValue for Comment nodes shouldn't return the comment delimiters.  See
the table in

http://www.w3.org/TR/REC-DOM-Level-1/level-one-core.html#ID-1950641247

but especially the description of "content of a comment" in

http://www.w3.org/TR/REC-DOM-Level-1/level-one-core.html#ID-1728279322

Comment 1

[vidur (gone)]

A parser issue that's described in bug 5544. Note that 5544 may need to be
REOPENED - Rick backed out his fix for it because of problems with comments in
SCRIPT elements. He'll put in an alternate fix soon.

*** This bug has been marked as a duplicate of 5544 ***

Comment 2

[phillip]

verified.

Comment 3

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Reopening.  rickg marked bug 5544 wontfix after I reopened it, giving a reason
that I'm not sure is true anymore.  (It doesn't seem to me, through the DOM,
that script or style elements contain any comment nodes anymore.  They
shouldn't, either.  See bug 7853)  I would think it's easier to fix there than
by working around it in the DOM, because there's a lot to work around.  However,
you can deal with that ;-).  See
http://www.fas.harvard.edu/~dbaron/dom/test/one-core-html/Comment for what needs
doing.  (And compare it to
http://www.fas.harvard.edu/~dbaron/dom/test/one-core-xml/Comment .)

Comment 4

[leger]

Clearing Duplicate resolution due to Reopen.

Comment 5

[vidur (gone)]

*** Bug 5544 has been marked as a duplicate of this bug. ***

Comment 6

[vidur (gone)]

Fix ready to go when tree opens today.

Comment 7

[vidur (gone)]

Fixed on 8/25/1999.

Comment 8

[gerardok]

QA Contact massive update.

Comment 9

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Verified fixed, 1999-10-08-08-M11 Linux apprunner.

Comment 10

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This has regressed.  Reopening.

I think it would probably be much easier to fix bug 15904 if the delimiters were
not stored in the content model (at least when the delimiters are properly
formed, which is all that really matters for either bug).  That is, I think it
would automatically fix said bug.

STEPS TO REPRODUCE:
 * load http://www.fas.harvard.edu/~dbaron/dom/test/one-core-html/Comment
 * click "test Comment"

EXPECTED RESULTS:
 * second, third, and fourth tests green (if you fix this the "right" way, all
the tests should become green)

ACTUAL RESULTS:
 * only the first test in the entire page is green

TESTED ON:
 * Linux viewer, build from morning of 1999-11-05

Comment 11

[leger]

Clearing FIXED resolution due to reopen. Since this was on M10 and that is over,
moving to M11 for consideration.

Comment 12

[vidur (gone)]

Reassigning to Waqar - he has a fix for this.

Comment 13

[waqar]

Fix check in, marking it as closed.

Comment 14

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This shows no sign of being fixed in Linux mozilla 1999-11-12-15-M12. Reopening.
Did you *really* check in the fix?

Comment 15

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

I'm beginning to think the builds on mozilla.org are mislabeled and I'm really
using the build 1999-11-12-18-M11. (I downloaded the file labeled
1999-11-12-15-M12, and the build ID is 1999111218...)

Comment 16

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Re-resolving based on the 1999-11-13-08-M12 build. I think the build I had was
an M11 one.

Comment 17

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Marking verified.