60783 - not deleting all the news passwords & usersname when deleing a news account

Status: VERIFIED FIXED

(MailNews Core :: Backend, defect, P3)

Description

[(not reading, please use [e-mail] instead)]

we need to override it to forget the username and password for the server and
any groups on the server.

we will need to call nsMsgNewsFolder::ForgetGroupUsername(),
nsMsgNewsFolder::ForgetGroupPassword() for all folders, starting with the root
folder (for the news account) and then all the children (for the groups).

Comment 1

[(not reading, please use [e-mail] instead)]

setting QA contact to nbaca.

accepting.

Comment 2

[(not reading, please use [e-mail] instead)]

as I mentioned earlier, the fix is to override ForgetPassword() for
nsNntpIncomingServer

Comment 3

[Andrew Taylor]

Attachment: Overrides the ForgetPassword in nsNntpIncomingServer

Comment 4

[(not reading, please use [e-mail] instead)]

andrew, you are a machine!  

I've been away on vacation, and I just got to this bug email.

let me review your patch.

Comment 5

[(not reading, please use [e-mail] instead)]

overall, a great patch.

I've made some changes to your original patch.  I'll attach it for you to
review, and then I'll explain the changes I made.

adding bienvenu / mscott for the eventual super review.

Comment 6

[(not reading, please use [e-mail] instead)]

Attachment: a revised version of andrew's patch.

Comment 7

[(not reading, please use [e-mail] instead)]

as you can see, my changes are very minor.

instead of just returning on failure, I use NS_ENSURE_SUCCESS() so we'll assert
too.

also, I check the rv when forgetting the passwords and usernames.

finally, I keep track of any failures when forgetting the usernames and
passwords of the children.

something to note, this code works fine since right now all groups are direct
children of the server.  if we ever add category support, this will change and
this code will need to be change to recursively remove the username / passwords
for the children of the root.

but since category support is a while off, we can just check this in and log a
bug to remind us.

one more note:  this was a great patch.  keep them coming, andrew!

can I get a sr=?

Comment 8

[Syd Logan]

sr=syd

Comment 9

[(not reading, please use [e-mail] instead)]

thanks for the review.

marking fixed.

again, excellent patch.

Comment 10

[(not reading, please use [e-mail] instead)]

I logged #61798 to track the category issue.

Comment 11

[Ninoschka Baca]

Build 2001-02-19-08: NT4
Build 2001-02-19-04: Linux RH 6.2
Build 2001-02-22-08: Mac 9.04
Verified Fixed.

- Added Poisonivy, subscribed to a secure newsgroup, posted some messages which 
required a username and password. Deleted the news account, added the news 
account again in the same session, selected the secure newsgroup (it returned 
automatically, bug# 37454) and it prompted for a username and password, as 
expected.

- Tried similar steps but exited after removing the news server the first time, 
then restarted and added the news server and subscribed to the same secure 
newsgroup. Again it asked for a username and password, as expected.