60904 - impossible to modify a filter (OK edit rules doesn't work)

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect, P1)

Description

[Matp75]

creating a new filter works, ie when mail arrives, it goes in the good folder
It works when creating with one or more criteria
But when I wan't to modify the criteria of a existing filter, it never works
when I press Ok, it prints in the console window :
JavaScript error:
chrome://messenger/content/FilterEditor.js line 100: myFilterList has no properties
and the only possibility is to press cancel
I'm using the nighty build 20001121 (8h30)
I've just converted my mail from netscape 4, so I never had to use filters in
mozilla before

Comment 1

[laurel]

Yes, can reproduce on linux rh6.0, win98, mac os 9.0 using commercial trunk
build 11/21 -- OK when editing a filter doesn't work.  OK when creating new does
work.

Comment 2

[R.K.Aa.]

*** Bug 61303 has been marked as a duplicate of this bug. ***

Comment 3

[siebert]

Yes, I can confirm this bug on Mandrake 7.2, build 2000112821. 

Comment 4

[laurel]

Can we get a fix for this pretty soon?  Thanks.

Comment 5

[Christoph Sold]

Confirmed this bug on 2000113004, WinNT 4.0, too. In addition, it seems the OK
button does not work at all, neither does the Return or Enter key.

Comment 6

[Matthias Versen [:Matti]]

*** Bug 61981 has been marked as a duplicate of this bug. ***

Comment 7

[laurel]

*** Bug 62143 has been marked as a duplicate of this bug. ***

Comment 8

[scottputterman]

reassigning to varada.

Comment 9

[Matp75]

You can see the problematic file at
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/mailnews/base/search/resources/content/FilterEditor.js

I tried a nighty from beginning of october and it was working
I think the problem was introduced with the addition of a check for duplicate
filter names, which was introduced on november 17
the diff can be seen at
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/mailnews/base/search/resources/content&command=DIFF_FRAMESET&file=FilterEditor.js&rev2=1.34&rev1=1.33

I grabbed the source and did the whole painful compilation just to find it
coredump at startup :-( (perhaps this is related to the gcc version shipped with
RH7.0)
As I didn't find any way to make a modification to this file without recompiling
the whole (which is stupid because javascript is interpreted !), I think the
following patch could solve the problem (untested)
I hope somebody can test this

Comment 10

[Matp75]

Attachment: diff FilterEditor.js (add a check for null)

Comment 11

[varada]

Marking Fixed.
Review/SR = Alecf.
Thanks to [e-mail] for the helpful patch.

Comment 12

[laurel]

OK using:
2000-12-12-04 commercial trunk build win98
2000-12-12-09 commercial trunk build linux rh6.0
2000-12-12-08 commercial trunk build mac os 9.0

Comment 13

[laurel]

*** Bug 62404 has been marked as a duplicate of this bug. ***