61337 - problem with drawing of right arc with NOSHADE <HR>

Status: VERIFIED FIXED

(Core :: Layout, defect, P3)

Description

[Chris Waterson]

From [e-mail]

When drawing horizontal rule with NOSHADE attribute the bar with rounded
corners is drawn.
There is problem with drawing of right arc. To draw half of circle the
start angle must
be 270 and end angle 90 degrees (not 180). Otherwise 3/4 of circle are
drawn.
mozilla/layout/html/base/src/nsHRFrame.cpp (line 164) [28-nov-2000]

     Change:
        aRenderingContext.FillArc(x0 + width - diameter, y0,
                                  diameter, diameter, 270.0f, 180.0f);

     To:
        aRenderingContext.FillArc(x0 + width - diameter, y0,
                                  diameter, diameter, 270.0f, 90.0f);

Dainis Jonitis
Developer. OS/2 department, Printer Device driver development group
SWH Technology, Exigen group
Phone     [phone] (ext. 213)
Fax  [phone]

Comment 1

[Chris Waterson]

Attachment: proposed fix, as patch

Comment 2

[Chris Waterson]

karnaze, buster, can I get r= and sr=?

Comment 3

[buster]

sr=buster

Comment 4

[Chris Waterson]

Fix checked in.

Comment 5

[Chris Petersen]

Marking fixed in the March 6 Linux build.