61626 - Need to make langxxxx.xpi platform neutral

Status: VERIFIED FIXED

(SeaMonkey :: Installer, defect, P3)

Description

[tao]

As of now, there are a few platform-specific files in langpack as listed in the
page pointed in URL field.

The consequence is that we need to create langpacks for each platform. This
really defeat the advantage of sharing script files across platform.

One possible solution might be to put all platform files in the langpack and
let "XPInstall" to smartly install only the propriate platform-files. However,
now that we put all chrome files in jar, this proposal might become invalid.

Comment 1

[Daniel Veditz [:dveditz]]

Tao, What you're asking for requires some browser restructuring first before 
install folks can make any sense of it so I'm reassigning to you to find a 
better home for this bug.

Off the top of my head, all the platform files can be moved into their own 
top-level package of "platform" instead of scattering it amongst other packages 
like mail or navigator. Then these files could either be moved into 
platform-specific additional .jar files, *OR* could perhaps be moved into 
different directories and then only one of the contents.rdf files registered.

Either way the installer could then easily put the right chrome file or give 
correct arguments to registerChrome() based on platform. But only after this 
structural change has been made by someone else.

Comment 2

[tao]

*** Bug 61863 has been marked as a duplicate of this bug. ***

Comment 3

[Robert Kaiser]

As you might see when you're looking into 61863 (I know tao read it but I'm not
sure about others), you might see that I supposed a different approach there.
If we could place all platform specific entities in one XP .dtd file, we only
need different XUL files to access them. (I think we have different XUL already
now, don't we?)
So we could use the same Language Packs for all platforms, having all relevant
strings in them (As this is affecting only 5 .dtd files, the packs wouldn't grow
too much containing some "useless" strings for every platform :> )

Comment 4

[Bozhan Boiadzhiev]

as i see XPI "cross-palatfor installer" isn't cross platform.
XPI must be cross-platform

Comment 5

[Daniel Veditz [:dveditz]]

XPInstall is only as "cross-platform" as what it is trying to install. What if 
you use XPInstall to install binary libraries? Obviously you'd need a different 
zippy (.xpi) package for each platform but that is not due to some fault with 
XPInstall.

Comment 6

[Jaime Rodriguez, Jr.]

Adding intl and nsbeta1 keyword. Nominating for nsbeta1.

Comment 7

[Robert Kaiser]

Hmm, what's status on this issue?
As I'm developing on Linux, testers on Windows can't use my "Nightly XPI Packs"
for satisfying work, e.g. Windows-Integration is wiped out by the pack which
"only" includes translations of files/strings from Linux en-US.jar!

Comment 8

[tao]

The patch is ready for testing and review. I tested it on Windows and Linux and
am testing it on Mac. The later took longs than I thought; haven't got a good
Mac build. Hope that I could wrap up the testing on Mac and submit the patch for
review this afternoon.

Comment 9

[tao]

Attachment: (mozilla) patch to separate platform-specific files from en.jar

Comment 10

[tao]

Attachment: (mozilla) patch to installer script/files to re-package platform files

Comment 11

[tao]

http://bugscape.netscape.com/show_bug.cgi?id=3779 holds the patch for the 
commercial tree.

Comment 12

[tao]

Attachment: centralize platform-depend files in chrome://***-platform/locale/*

Comment 13

[tao]

r=ssu,sr=dveditz

Comment 14

[Grace Bush]

verify code fixes