61748 - signature file is truncated

Status: VERIFIED FIXED

(MailNews Core :: Composition, defect, P3)

Description

[Colin Blake]

After configuring a signature file, only the first line of text from that file 
is ever used. Is the first line is empty, then you don't see any text from the 
signature file (although you do still get the "--" at the end of the mail).

Comment 1

[Colin Blake]

For the signature file to be completely read, it has to be in STREAM-LF format. 
If its in VARIABLE LENGTH format then only the first line is used. So the 
workaround is to convert your signature file to STREAM-LF format. For example:

$ create stmlf.fdl
RECORD
 FORMAT stream_lf
$ convert /fdl=stmlf old-sig.txt new-sig.txt

Comment 2

[Colin Blake]

The problem is this. The signature file is read using 
nsMsgCompose::LoadDataFromFile, and the way LoadDataFromFile is coded (see 
http://lxr.mozilla.org/seamonkey/source/mailnews/compose/src/nsMsgCompose.cpp#19
69), it only makes ONE read to the file. If it doesn't get the entire contents 
in that one read, then tough, the remainder is ignored. On OpenVMS, when reading 
 VARIABLE LENGTH format files, only one line is returned with each read 
operation. Hence the problem.

The correct fix (for all platforms since read does not guarantee to read all the 
requested characters in one operation) is to loop until either readSize chars 
are read or until EOF is hit (read returns 0).

Comment 3

[Colin Blake]

Re-assigned to MailNews default owner. If you want me to submit a patch for this 
let me know.

Colin.

Comment 4

[Jean-Francois Ducarroz]

patches are always welcome...

Comment 5

[Colin Blake]

Attachment: patch for MOZILLA_0_6_BRANCH

Comment 6

[Colin Blake]

Attachment: patch for truck

Comment 7

[Colin Blake]

Patches only tested on OpenVMS.

Comment 8

[Jean-Francois Ducarroz]

Will look at it very soon...

Comment 9

[Jean-Francois Ducarroz]

I've just tested it on Mac and it works well, even when I simulate a read in
several part (like does apparently OpenVMS). R=ducarroz

Comment 10

[David :Bienvenu]

sr=bienvenu

Comment 11

[Scott MacGregor]

sr=mscott

Comment 12

[Jean-Francois Ducarroz]

Fixed and checked in. Thanks [e-mail] for providing the patch.

Comment 13

[[e-mail] (gone - use [e-mail] instead)]

Fix is in, no regression reported, VERIFIED.